iframe-proxy

B67687 · 2026-04-29T09:43:14Z

I have read the Contributing Guide.

Closes #566

Summary

Add explicit version manifests to follow bucket pattern:

oraclejdk-21.json - Oracle JDK 21 LTS (explicit)
oraclejdk-26.json - Oracle JDK 26 (explicit)

This gives users the choice between:

oraclejdk - always latest (currently JDK 26)
oraclejdk-lts - latest LTS (currently JDK 21)
oraclejdk-26 - explicit JDK 26 pin
oraclejdk-21 - explicit JDK 21 LTS pin

Validation

checkurls.ps1 oraclejdk-21 -> [1][1][0]
checkurls.ps1 oraclejdk-26 -> [1][1][0]

Context Update

Oracle JDK 21, 25, and 26 are now free to use under the Oracle No-Fee Terms and Conditions (NFTC). This addresses the concern raised in Discussion #517 about Oracle JDK requiring sign-in - that policy has changed, making explicit version manifests appropriate.

Summary by CodeRabbit

New Features
- Oracle JDK 21 LTS (21.0.11) is now available for Windows 64-bit.
- Oracle JDK 26 (26.0.1) is now available for Windows 64-bit.
- Installer manifests include automatic version detection and autoupdate support.
- Installation sets JAVA_HOME and adds the JDK bin directory to PATH.

coderabbitai · 2026-04-29T09:43:21Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 04cbf920-a1ce-40cf-816b-15672ad01681

📥 Commits

Reviewing files that changed from the base of the PR and between 98ac885 and 0e23f64.

📒 Files selected for processing (1)

bucket/oraclejdk-26.json

Walkthrough

Adds two new Scoop package manifests: oraclejdk-21 (jdk-21.0.11) and oraclejdk-26 (jdk-26.0.1) describing Windows x64 ZIP downloads with pinned SHA256s, extraction into jdk-<version>, JAVA_HOME/PATH env, checkver scraping, and autoupdate templates.

Changes

Oracle JDK Manifests

Layer / File(s)	Summary
Oracle JDK manifests (metadata, env, checkver, autoupdate) `bucket/oraclejdk-21.json`, `bucket/oraclejdk-26.json`	Add new JSON manifests for Oracle JDK 21.0.11 and 26.0.1: package metadata (description, homepage, license, version), 64-bit Windows ZIP URLs with pinned SHA256, extraction into `jdk-<version>` directories, `env` settings for `JAVA_HOME` and `PATH`, `checkver` regex scraping from Oracle pages, and `autoupdate` templates that derive future URLs and SHA256 locations.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

graalvm-oracle*: update releases and fix checkver #591: Related adjustments to Oracle JDK 21 manifest version detection and URL/sha256 handling.

Suggested reviewers

se35710
chawyehsu

Poem

🐇 I hop the build with manifest bright,
Zips and SHA pins snug in the night,
Checkver sniffs updates, autoupdate sings,
JAVA_HOME set — the meadow springs,
Hooray for builds and carrot things!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	Title accurately summarizes the primary change: adding explicit version manifests for Oracle JDK 21 and 26.
Description check	✅ Passed	Description includes issue reference, clear summary, validation output, and relevant context about Oracle's free-tier policy change.
Linked Issues check	✅ Passed	PR adds oraclejdk-21 and oraclejdk-26 manifests fulfilling issue `#566`'s core objectives: providing explicit version pins and preventing unintended upgrades across major versions.
Out of Scope Changes check	✅ Passed	Changes are focused on adding two new JSON manifest files for explicit JDK versions as specified in issue `#566`; no unrelated modifications detected.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai · 2026-04-29T10:05:42Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-04-29T10:40:20Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai · 2026-04-29T10:41:39Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@bucket/oraclejdk-26.json`:
- Around line 17-20: The checkver regex currently matches any JDK major version;
update the checkver.regex to only capture major version 26 (e.g., anchor the
pattern to match "Java SE Development Kit 26..." rather than any digits) so
$majorVersion remains 26; specifically modify the "checkver" -> "regex" value to
constrain the captured version to major 26 (and keep the capture group format
unchanged so downstream $majorVersion parsing continues to work).

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d2b0088f-c5a3-4371-82a1-b1b87c6e3183

📥 Commits

Reviewing files that changed from the base of the PR and between ef20951 and 3e72ca5.

📒 Files selected for processing (2)

bucket/oraclejdk-21.json
bucket/oraclejdk-26.json

coderabbitai · 2026-04-29T11:42:39Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

github-actions · 2026-04-29T15:45:23Z

github-actions · 2026-04-29T15:55:38Z

coderabbitai · 2026-04-30T02:04:42Z

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

github-actions · 2026-04-30T02:08:11Z

The previous regex could match any JDK version on the Oracle downloads page (25, 21, etc.). Pinning to ensures only JDK 26 versions are captured.

github-actions · 2026-05-22T00:21:12Z

B67687 · 2026-06-13T01:05:16Z

coderabbitai Bot reviewed Apr 29, 2026

View reviewed changes

Comment thread bucket/oraclejdk-26.json Outdated

github-actions Bot added the manifest-fix-needed label Apr 29, 2026

B67687 added 3 commits April 29, 2026 23:47

feat: add explicit version manifests

3ed40c1

fix: anchor checkver regex to match only JDK 26

730448d

chore: add trailing newline

1707195

B67687 force-pushed the add/oraclejdk-versions-v2 branch from 1f920d0 to 1707195 Compare April 29, 2026 15:47

B67687 added 2 commits April 29, 2026 23:51

fix: simplify checkver regex for oraclejdk-26

ae8313f

chore: add trailing newline to oraclejdk-26.json

98ac885

github-actions Bot added review-needed and removed manifest-fix-needed labels Apr 29, 2026

fix: pin oraclejdk-26 checkver regex to major version 26

0e23f64

The previous regex could match any JDK version on the Oracle downloads page (25, 21, etc.). Pinning to ensures only JDK 26 versions are captured.

B67687 closed this by deleting the head repository Jun 8, 2026

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

B67687 commented Apr 29, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Validation

Context Update

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Apr 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

oraclejdk-21

oraclejdk-26

Uh oh!

github-actions Bot commented Apr 29, 2026

oraclejdk-21

oraclejdk-26

Uh oh!

coderabbitai Bot commented Apr 30, 2026

Uh oh!

github-actions Bot commented Apr 30, 2026

oraclejdk-21

oraclejdk-26

Uh oh!

github-actions Bot commented May 22, 2026

oraclejdk-21

oraclejdk-26

Uh oh!

B67687 commented Jun 13, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

B67687 commented Apr 29, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Apr 29, 2026 •

edited

Loading