iframe-proxy

Federicorao · 2026-06-12T12:04:29Z

This PR follows our AI policy

Routes the native _json scanner integer path through rustpython_common::int::bytes_to_int with the live vm.state.int_max_str_digits value, matching the int() conversion path and the pure-Python JSON decoder. Adds snippet coverage for the boundary where an integer with exactly the configured digit limit parses, while one digit over the limit raises ValueError.

Local verification:

python3.14 -m py_compile extra_tests/snippets/stdlib_json.py
python3.14 extra_tests/snippets/stdlib_json.py

Could not run local Rust checks because cargo is not installed in this environment; CI will validate the Rust crate build and formatting.

AI assistance disclosure: OpenAI GPT-5 was used to inspect the issue and review feedback, draft the patch, and run local verification; the changes are disclosed in the commit with an Assisted-by trailer.

Summary by CodeRabbit

Bug Fixes
- JSON integer parsing now enforces the VM's integer-string length limit, returning an error for overly long integer literals while preserving correct parsing for valid integers.
Tests
- Added a regression test that verifies the length limit is enforced and that valid integer strings continue to parse successfully.

coderabbitai · 2026-06-12T12:04:47Z

📝 Walkthrough

Walkthrough

Replaces JSON integer parsing to use bytes_to_int with the VM's int_max_str_digits limit and adds a stdlib test ensuring json.loads rejects oversized integer literals while accepting threshold-length and small integers.

Changes

JSON integer size limit regression test and implementation

Layer / File(s)	Summary
JSON integer parsing implementation `crates/stdlib/src/json.rs`	Imports `rustpython_common::int::bytes_to_int` and `handle_bytes_to_int_err`, and updates `JsonScanner::parse_number` to convert ASCII digit slices with `bytes_to_int` using `vm.state.int_max_str_digits`, mapping errors through `handle_bytes_to_int_err` and returning the VM integer object.
JSON int_max_str_digits regression test `extra_tests/snippets/stdlib_json.py`	Adds a test that temporarily sets `sys.int_max_str_digits` to the threshold, asserts a too-long integer string raises `ValueError`, confirms a threshold-length integer and `'42'` parse successfully, and restores the original limit in `finally`.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related issues

json.loads ignores sys.int_max_str_digits (decodes an over-long int instead of raising ValueError) #8051: The change implements the suggested fix by replacing BigInt::from_str with bytes_to_int using vm.int_max_str_digits and adds a test validating json.loads enforces the limit.

Possibly related PRs

RustPython/RustPython#7982: Also modifies JSON number parsing in crates/stdlib/src/json.rs; related to handling parsed number bytes and conversion.

Suggested reviewers

ShaharNaveh

Poem

🐰 A tiny rabbit checks each digit,

Too long? it says "No, that's not right!"
At the threshold the number's fine,
Forty-two hops in a single line,
Limits reset — the tests take flight. 🥕

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the main change: adding enforcement of sys.int_max_str_digits in the native json.loads implementation.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

ShaharNaveh

Hi, thanks for the PR!

Can you please read our AI policy, and check the box you've read it in your PR comment (I've edited your comment)

Rust fix required but cannot be provided without original file content.

Not sure what you mean by that, you can create your own MRE and test it against that. ATM we cannot merge your test as it would only make the CI fail, it doesn't fix anything unless I'm missing something

ShaharNaveh · 2026-06-12T12:18:26Z

+import sys
+_orig_limit = sys.get_int_max_str_digits()
+try:
+    sys.set_int_max_str_digits(100)


Also, this wouldn't work as the minimum value for it is 600

Route native _json integer parsing through bytes_to_int with the live VM digit limit, matching int() and the pure-Python JSON path. Add snippet coverage for the boundary. Assisted-by: OpenAI GPT-5:gpt-5

coderabbitai

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@extra_tests/snippets/stdlib_json.py`:
- Line 266: The import statement "import sys" is located after top-level code
causing Ruff E402; remove the "import sys" from its current spot and add it to
the module's top-level import block alongside other stdlib imports (i.e., the
file's initial import section) so that "sys" is imported before any non-import
top-level statements.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Pro

Run ID: 5e75a5c2-6d28-44aa-adec-79c58ec2a330

📥 Commits

Reviewing files that changed from the base of the PR and between 0902b83 and 16679d3.

📒 Files selected for processing (2)

crates/stdlib/src/json.rs
extra_tests/snippets/stdlib_json.py

coderabbitai · 2026-06-12T13:51:18Z

    raise AssertionError("expected JSONDecodeError")
+
+# Test that json.loads honors sys.int_max_str_digits
+import sys


⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash python - <<'PY' import ast from pathlib import Path path = Path("extra_tests/snippets/stdlib_json.py") tree = ast.parse(path.read_text(), filename=str(path)) seen_non_import = False late_imports = [] for node in tree.body: if ( isinstance(node, ast.Expr) and isinstance(getattr(node, "value", None), ast.Constant) and isinstance(node.value.value, str) and not seen_non_import ): continue if isinstance(node, (ast.Import, ast.ImportFrom)): if seen_non_import: late_imports.append(node.lineno) else: seen_non_import = True print({"late_import_lines": late_imports}) PY

Repository: RustPython/RustPython

Length of output: 94

Move import sys into the top-level import section (Ruff E402)

extra_tests/snippets/stdlib_json.py has import sys on line 266, after non-import top-level statements; this layout can trigger Ruff E402. Move import sys up into the module’s import block.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@extra_tests/snippets/stdlib_json.py` at line 266, The import statement "import sys" is located after top-level code causing Ruff E402; remove the "import sys" from its current spot and add it to the module's top-level import block alongside other stdlib imports (i.e., the file's initial import section) so that "sys" is imported before any non-import top-level statements.

Source: Coding guidelines

fanninpm · 2026-06-12T16:54:17Z

ShaharNaveh requested changes Jun 12, 2026

View reviewed changes

ShaharNaveh reviewed Jun 12, 2026

View reviewed changes

Honor int_max_str_digits in native JSON scanner

16679d3

Route native _json integer parsing through bytes_to_int with the live VM digit limit, matching int() and the pure-Python JSON path. Add snippet coverage for the boundary. Assisted-by: OpenAI GPT-5:gpt-5

Federicorao force-pushed the codex/issue-8051-1781265710 branch from 0902b83 to 16679d3 Compare June 12, 2026 13:45

Federicorao changed the title ~~Add test to verify that json.loads honors sys.int_max_str_digits; Rust fix required but cannot be provided without origi~~ Honor sys.int_max_str_digits in native json.loads Jun 12, 2026

coderabbitai Bot reviewed Jun 12, 2026

View reviewed changes

Fix JSON int limit CI failures

2707f54

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Honor sys.int_max_str_digits in native json.loads#8087

Honor sys.int_max_str_digits in native json.loads#8087
Federicorao wants to merge 2 commits into
RustPython:mainfrom
Federicorao:codex/issue-8051-1781265710

Federicorao commented Jun 12, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jun 12, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

ShaharNaveh left a comment •

edited

Loading

Uh oh!

ShaharNaveh Jun 12, 2026

Uh oh!

coderabbitai Bot left a comment

Uh oh!

coderabbitai Bot Jun 12, 2026

Uh oh!

fanninpm commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

Federicorao commented Jun 12, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jun 12, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related issues

Possibly related PRs

Suggested reviewers

Poem

❌ Failed checks (1 warning)

Uh oh!

ShaharNaveh left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ShaharNaveh Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot Jun 12, 2026

Choose a reason for hiding this comment

Uh oh!

fanninpm commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Federicorao commented Jun 12, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jun 12, 2026 •

edited

Loading

ShaharNaveh left a comment •

edited

Loading