{{ message }}
Replace .Result with synchronous HttpClient.Send() in TestJsonCommand#27624
Open
euxaristia wants to merge 1 commit into
Open
Replace .Result with synchronous HttpClient.Send() in TestJsonCommand#27624euxaristia wants to merge 1 commit into
.Result with synchronous HttpClient.Send() in TestJsonCommand#27624euxaristia wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Test-Json cmdlet’s schema auto-fetch implementation to avoid blocking on Task.Result by switching the HTTP retrieval logic from HttpClient.GetStringAsync(...).Result to a synchronous HttpClient.Send(...) flow.
Changes:
- Replaces
GetStringAsync(...).ResultwithHttpClient.Send(...)+ synchronous content read inSchemaRegistry.Global.Fetch. - Introduces explicit
HttpResponseMessagedisposal viausing var.
Comment on lines
+149
to
+150
…mmand` The use of `.Result` on a `Task<string>` can cause deadlocks and thread-pool starvation when called from contexts with a synchronization context. Replace with `HttpClient.Send()` + `Content.ReadAsString()` for the synchronous HTTP call path.
euxaristia
force-pushed
the
fix/http-result-deadlock
branch
from
f90085f to
e28381c
Compare
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Replace
client.GetStringAsync(uri).Resultwithclient.Send(new HttpRequestMessage(HttpMethod.Get, uri))+response.Content.ReadAsString()in theProcessJsonmethod.PR Context
The
.Resultproperty on aTask<T>can cause deadlocks (e.g., when theSynchronizationContextis captured and the continuation is posted back to a single-threaded context) and contributes to thread-pool starvation. The replacement usesHttpClient.Send()withreadResponse: falseto avoid buffering the entire response, then reads the content synchronously withReadAsString(). This achieves the same synchronous blocking semantics without the deadlock risk.PR Checklist