{{ message }}
Replace lock(this) with private lock object in CompiledScriptBlockData#27619
Open
euxaristia wants to merge 1 commit into
Open
Replace lock(this) with private lock object in CompiledScriptBlockData#27619euxaristia wants to merge 1 commit into
lock(this) with private lock object in CompiledScriptBlockData#27619euxaristia wants to merge 1 commit into
Conversation
…Data` Using `this` as a synchronization object is dangerous because external code could also lock on the same instance, leading to deadlocks or unexpected contention. Replace with a dedicated `_lock` field.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR replaces synchronization on the CompiledScriptBlockData instance (lock(this)) with a dedicated private lock object (lock(_lock)), reducing the risk of external code locking on the same instance and causing unexpected contention or deadlocks.
Changes:
- Replaced six occurrences of
lock(this)withlock(_lock)inCompiledScriptBlockData. - Introduced a private readonly lock field (
_lock) to serve as the synchronization root for the class.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Replace six instances of
lock(this)withlock(_lock)using a dedicated private readonly object field to avoid synchronizing on the instance itself.PR Context
Using
thisas a synchronization object is dangerous because external code could also lock on the same instance, leading to deadlocks or unexpected contention. This is a common threading anti-pattern flagged by static analysis.PR Checklist