iframe-proxy

NathanWalker · 2026-04-14T03:13:19Z

improvements to the NativeScript CLI's Vite HMR workflow, focusing on reliability, developer experience, and automation. The CLI now fully manages the Vite dev server lifecycle and the Android adb reverse port forwarding needed for HMR, eliminating the need for developers to manually coordinate these steps or use external tooling. It also ensures that Vite build outputs are always correctly copied to the platform destination, fixing prior issues with missing or stale bundles.

Summary by CodeRabbit

New Features
- Enabled Android Vite HMR using automatic device-to-host tunneling during initial sync, with the mapping re-established before app launch.
- Added long-lived Vite dev-server support in watch mode, including readiness checks and initial artifact copying.
Bug Fixes
- Improved the reliability of Vite dist/output handling and made adb reverse setup best-effort with safe fallbacks.
Documentation
- Documented the Vite dist folder naming/override behavior used for platform app output copying.
Chores
- Bumped version to 9.1.0-alpha.11.

coderabbitai · 2026-05-22T17:50:35Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 151da14b-2045-4c4e-af61-82be333e23a0

📥 Commits

Reviewing files that changed from the base of the PR and between 6442af7 and 37019bb.

📒 Files selected for processing (1)

package.json

🚧 Files skipped from review as they are similar to previous changes (1)

package.json

📝 Walkthrough

Walkthrough

Adds Vite HMR support with Vite output path handling, dev-server lifecycle management, Android adb reverse wiring, related tests, and a package version bump.

Changes

Vite HMR: constant, bundler service, and run controller

Layer / File(s)	Summary
VITE_DIST_FOLDER_NAME and dist path resolution `lib/constants.ts`, `lib/services/bundler/bundler-compiler-service.ts`	Exports `VITE_DIST_FOLDER_NAME = ".ns-vite-build"`, adds `getViteDistOutputPath()` using `NS_VITE_DIST_DIR` or the constant, and updates Vite output path references to use that helper. Minor formatting updates in `constants.ts` are included.
Vite dev server lifecycle in BundlerCompilerService `lib/services/bundler/bundler-compiler-service.ts`	Adds `viteServeProcesses`, starts `vite serve` during `compileWithWatch`, probes TCP readiness, copies Vite output into native app destinations on successful non-watch builds, and stops the managed Vite process in `stopBundlerForPlatform`.
RunController adb reverse HMR wiring `lib/controllers/run-controller.ts`	Injects `staticConfig` into RunController, runs Android Vite HMR reverse setup before prepare and before launch, and adds helpers for HMR port resolution, env-flag parsing, bounded adb reverse execution, and reverse verification.
BundlerCompilerService tests `test/services/bundler/bundler-compiler-service.ts`	Adds logger and cleanupService stubs, covers `getViteDistOutputPath` for default and overridden paths, and verifies `compileWithWatch` event emission behavior across initial and incremental Vite builds.
RunController tests and wiring stubs `test/controllers/run-controller.ts`	Registers a `staticConfig` test stub, reformats `mockDevicesService` and test case literals, and preserves the existing watch-mode and stop-mode assertions.

Package version bump

Layer / File(s)	Summary
Version bump to 9.1.0-alpha.11 `package.json`	Changes the version field in `package.json`.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~60 minutes

Poem

🐇 Hop hop, the tunnel is laid,
adb reverse makes HMR stay!
Vite server hums and ports align,
.ns-vite-build now works just fine.
Pre-build, pre-launch, the flow is bright —
Rabbit-approved, all set for flight ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

Provides ability to run multiple platforms builds in parallel.

NathanWalker changed the title ~~fix(bundler): vite double restart~~ fix(bundler): vite build/prepare improvements May 22, 2026

NathanWalker added this to the 9.1 milestone Jun 9, 2026

NathanWalker force-pushed the feat/vite-bundler-improvements branch 4 times, most recently from 346cae6 to fd5d69e Compare June 15, 2026 17:08

NathanWalker changed the title ~~fix(bundler): vite build/prepare improvements~~ feat(bundler): vite build/prepare + dx improvements Jun 15, 2026

NathanWalker marked this pull request as ready for review June 15, 2026 17:10

NathanWalker force-pushed the feat/vite-bundler-improvements branch from fd5d69e to 45314a2 Compare June 26, 2026 00:49

NathanWalker added 11 commits June 25, 2026 18:46

fix(bundler): vite double restart

a6f76fe

chore: 9.0.7-dev.0

ca2d07e

fix(vite): build/prepare handling for the bundle

89d39a0

chore: 9.1.0-alpha.1

5a286ae

feat: allow custom vite dist folder name

50c3c61

Provides ability to run multiple platforms builds in parallel.

chore: 9.1.0-alpha.2

b87d223

feat: allow proper adb reverse debug sessions

e55ec5e

chore: 9.1.0-alpha.3

795a267

feat: cli managed vite process, seamless and easier to work with

318920a

chore: 9.1.0-alpha.5

37f17e6

chore: 9.1.0-alpha.9

6442af7

NathanWalker force-pushed the feat/vite-bundler-improvements branch from 45314a2 to 6442af7 Compare June 26, 2026 01:46

chore: 9.1.0-alpha.11

37019bb

Sunbelt Computer Software

PL/B Language Development and Support

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

feat(bundler): vite build/prepare + dx improvements#6010

feat(bundler): vite build/prepare + dx improvements#6010
NathanWalker wants to merge 12 commits into
mainfrom
feat/vite-bundler-improvements

NathanWalker commented Apr 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented May 22, 2026 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

NathanWalker commented Apr 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented May 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

NathanWalker commented Apr 14, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented May 22, 2026 •

edited

Loading