{{ message }}
feat: Java methods returning java.lang primitive#1710
Open
farfromrefug wants to merge 1 commit into
Open
Conversation
converted to JS corresponding type
Member
Contributor
Author
|
@triniwiz @NathanWalker can we consider this one now (needs to be updated though)? I am facing this again while implementing a new plugin where i have to pass |
Contributor
Author
|
@triniwiz in this PR i handle callback return result type. And i see it is tricky as it is a breaking change. |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
converted to JS corresponding type. This is an issue which always bugged me on difference between Float/Integer/Double/Long and basic float/int/long... handling
This is kind of a breaking change since JS codes doing
floatValue()before wont work anymore and will crash.We have a few in N core for which i ll create a PR