feat: read data descriptor from binary by Its-Just-Nans · Pull Request #990 · zip-rs/zip2 · GitHub
Skip to content

feat: read data descriptor from binary - #990

Merged
Its-Just-Nans merged 2 commits into
masterfrom
fix-read-data-descriptor
Sep 15, 2026
Merged

Its-Just-Nans merged 2 commits into
masterfrom
fix-read-data-descriptor

Conversation

@Its-Just-Nans

Copy link
Copy Markdown
Member

@amazon-q-developer amazon-q-developer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR successfully adds a new test for reading data descriptors from binary format. The code follows Conventional Commits format and compiles without issues. The implementation correctly validates that directories don't have data descriptors and demonstrates parsing the data descriptor structure from the binary format.


You can now have the agent implement changes and create commits directly on your pull request's source branch. Simply comment with /q followed by your request in natural language to ask the agent to make changes.

@Its-Just-Nans
Its-Just-Nans added this pull request to the merge queue Sep 15, 2026
Merged via the queue into master with commit d2d05e8 Sep 15, 2026
134 checks passed
@Its-Just-Nans
Its-Just-Nans deleted the fix-read-data-descriptor branch September 15, 2026 14:10
@Pr0methean Pr0methean mentioned this pull request Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant