{{ message }}
Repository navigation
feat: add len, is_empty and entry to ZipArchiveMetadata - #1015
Merged
Pr0methean merged 1 commit intoSep 28, 2026
Merged
Conversation
Contributor
Author
Pr0methean
approved these changes
Sep 28, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Follow-up to #1012.
We're working on streaming large archives and we plan the work from the central directory first, then open readers only for the entries we actually need.
by_indexreads the local header for each entry and needs&mut, andby_index_dataavoids that but still needs theZipArchive<R>around. What we really want is to passArc<ZipArchiveMetadata>to other threads and read entries from it directly, without carrying a reader.So this adds
len,is_emptyandentryonZipArchiveMetadata.entryreturns the sameZipFileEntryasby_index_data(andFileNotFoundwhen out of range), andby_index_data/ZipArchive::lennow just call into it. Added a couple of tests comparingentry(i)againstby_index(i).