{{ message }}
SQL codestyle: trim spacing around 'INHERITS' table list#13397
Open
jayaddison wants to merge 1 commit into
Open
SQL codestyle: trim spacing around 'INHERITS' table list#13397jayaddison wants to merge 1 commit into
jayaddison wants to merge 1 commit into
Conversation
This is _pedantic_ consistency with other comma-separated SQL lists - e.g. `VALUES`, `IN`, `DISTINCT ON` - and subqueries, where generally parantheses are not inner-padded by space characters.
Contributor
Author
Member
I think the spaces were always there, dating back to when it was first implemented in b490534 overall I don't have a preference here, not having the spaces may be better, but I think the ratio noise vs usefulness it quite low here so I'm inclined to leave as is |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is pedantic consistency with other comma-separated SQL lists - e.g.
VALUES,IN,DISTINCT ON- and subqueries, where generally parantheses are not inner-padded by space characters.The test cases updated illustrate the difference:
I noticed during source code diff review between v2.0.50 and v2.0.51 that spaces are added on each side within the parentheses containing the inherited table list.
If it's intentional to draw attention to the fact that these are tables and not column names -- then my apologies, that would seem sorta reasonable.
The parsing/interpretation of these spaces seems unlikely to be the change that microscopically moves the performance needle enough to offset the climate crisis -- indeed the overhead of reading this and responding may be larger -- this is purely me being pedantic.
Checklist
This pull request is:
Have a nice day!
(you too; plus weekend)