Add experimental flag for bind struct by sagikazarmark · Pull Request #1854 · spf13/viper · GitHub
Skip to content

Add experimental flag for bind struct - #1854

Merged
sagikazarmark merged 2 commits into
masterfrom
experimental-bind-struct
Jun 5, 2024
Merged

sagikazarmark merged 2 commits into
masterfrom
experimental-bind-struct

Conversation

@sagikazarmark

Copy link
Copy Markdown
Collaborator

Fixes #1851
Fixes #1721

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark added the kind/enhancement New feature or request label Jun 4, 2024
@github-actions

github-actions Bot commented Jun 4, 2024

Copy link
Copy Markdown

@andig

andig commented Jun 7, 2024 •

Copy link
Copy Markdown
Contributor

Love it- much simpler to use than the compile switches. Doesn't this also replace #1715? Wondering why that's not visible in the diff? However, it's not possible to use with the global viper instance, right?

@sagikazarmark

Copy link
Copy Markdown
Collaborator Author

The build tag didn't go away. You can still set it which means it's going to be enabled by default for every Viper instance. Or you can enable it on a case-by-case basis using the option.

@haoming29

haoming29 commented Jun 24, 2024 •

Copy link
Copy Markdown

haoming29 added a commit to haoming29/pelican that referenced this pull request Jun 24, 2024
jhiemstrawisc pushed a commit to PelicanPlatform/pelican that referenced this pull request Jun 25, 2024
haoming29 added a commit to haoming29/pelican that referenced this pull request Jun 28, 2024
patrickbrophy pushed a commit to patrickbrophy/pelican that referenced this pull request Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make features.BindStruct a Variable or an Option, Instead of Build Constraints Enable experimental features runtime

3 participants