{{ message }}
Repository navigation
fix(security): retire the eMudhra TLS preload for Node 24.22.1's native fix - #2489
Merged
Merged
Conversation
Contributor
Windscar
approved these changes
Oct 21, 2026
Windscar
left a comment
Windscar
left a comment
Contributor
There was a problem hiding this comment.
Looks good. The preload removal is covered by the patched runtime pins.
Reviewed: Node's TLS fix, Docker image platforms, CI Node versions, remaining preload references, and package and build cleanup.
Contributor
keeganthomp
approved these changes
Oct 21, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retires the temporary eMudhra TLS preload from #2465: Node v24.22.1 ships the native fix (nodejs/node#66871), a compiled-in blocklist of the eight compromised eMudhra/emSign intermediates.
node:24-slim@sha256:8cabefbd…86658(the complete 24.22.1 index: amd64, arm64, ppc64le), CIsetup-nodeon24.22.1(its manifest still stops at 24.22.0, so it falls back to nodejs.org), rootengines >=24.22.1.tls-trust.cjs, the API/Next imports, the Docker preload stage, CIBASH_ENV, and the TurboNODE_OPTIONSpassthrough. Keepsscripts/check-tls-trust.mjs.NODE_TLS_REJECT_UNAUTHORIZED=0goes with it; Node itself still warns.Verification:
check-tls-trust.mjson the pinned digest with no preload, amd64 + arm64: 12/12CERT_REVOKED, control connects (same check on 24.22.0 fails). typecheck 28/28,node --test scripts230/230. Local app not launched.