{{ message }}
Adds freeze and unfreeze functionality#507
Merged
tatatupi merged 18 commits intoMar 20, 2026
Merged
Conversation
Integrate upstream
g-abilio
changed the title
Contributor
Author
tatatupi
requested changes
Mar 6, 2026
tatatupi
left a comment
tatatupi
left a comment
Collaborator
There was a problem hiding this comment.
Ideally, in the example, when the change is made but the output is frozen, the status icon should reflect a warning sign.
| std::shared_ptr<NodeData> MathOperationDataModel::outData(PortIndex) | ||
| { | ||
| return std::static_pointer_cast<NodeData>(_result); | ||
| auto output = std::static_pointer_cast<NodeData>(_result); |
Collaborator
There was a problem hiding this comment.
Is this change really necessary?
Contributor
Author
There was a problem hiding this comment.
No! A commit that removed those changes has already been made. Thanks for noticing!
Contributor
Author
tatatupi
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of change
Description
This PR adds the option to freeze the node, that is the output will no longer be propagated. A demonstration of this functionality can be seen in the video below:
freeze_demo.mp4
The feature is triggered via setter method, and the example of the functionality can be found in the Random Number node.
Testing