{{ message }}
Fix OVN condition flapping during minor updates#1966
Open
karelyatin wants to merge 1 commit into
Open
Conversation
During minor updates, reconcileOVNControllers was called on every reconcile throughout all update phases, causing two issues: 1. OVNReadyCondition flapping: Since InitConditions() resets all conditions to Unknown on each reconcile, calling reconcileOVNControllers during later phases (RabbitMQ, Galera, etc.) could transiently flip OVNReadyCondition to False, blocking the OpenStackVersion controller from maintaining MinorUpdateOVNControlplane as True. 2. Metrics DaemonSet unnecessary restarts: reconcileOVNControllers passed an empty string for the metrics cert name, clearing the MetricsTLS fields on the OVNController CR. This changed the metrics config hash, causing two spurious DaemonSet rollouts — once when MetricsTLS was cleared during the update, and again when the normal reconcile path restored it after the update completed. Fix both by: - Skipping reconcileOVNControllers after the OVN controlplane phase completes, directly marking OVNReadyCondition True instead (needed because InitConditions() resets conditions each reconcile). - Passing the correct metrics cert name via EnsureOVNMetricsCert so MetricsTLS stays consistent when reconcileOVNControllers does run. There was another issue in ovn-operator for pre mature readiness, that is being fixed as part of openstack-k8s-operators/ovn-operator#587 Related-Issue: https://redhat.atlassian.net/browse/OSPRH-31318 Assisted-By: Claude Signed-off-by: Yatin Karel <ykarel@redhat.com>
Contributor
OpenStackControlPlane CRD Size Report
Threshold reference
|
Contributor
Author
|
/test openstack-operator-build-deploy-kuttl-4-18 |
Contributor
Author
|
/test openstack-operator-build-deploy-kuttl-4-18 |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During minor updates, reconcileOVNControllers was called on every reconcile throughout all update phases, causing two issues:
OVNReadyCondition flapping: Since InitConditions() resets all conditions to Unknown on each reconcile, calling reconcileOVNControllers during later phases (RabbitMQ, Galera, etc.) could transiently flip OVNReadyCondition to False, blocking the OpenStackVersion controller from maintaining MinorUpdateOVNControlplane as True.
Metrics DaemonSet unnecessary restarts: reconcileOVNControllers passed an empty string for the metrics cert name, clearing the MetricsTLS fields on the OVNController CR. This changed the metrics config hash, causing two spurious DaemonSet rollouts — once when MetricsTLS was cleared during the update, and again when the normal reconcile path restored it after the update completed.
Fix both by:
There was another issue in ovn-operator for pre mature readiness, that is being fixed as part of openstack-k8s-operators/ovn-operator#587
Related-Issue: https://redhat.atlassian.net/browse/OSPRH-31318
Assisted-By: Claude