{{ message }}
Repository navigation
Fix universal database endpoint cap - #20017
Merged
Merged
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
trask
marked this pull request as draft
September 8, 2026 00:43
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused implementation consistently enforces the fixed cap and covers the affected behavior.
Pull request overview
Enforces a universal five-endpoint cap for database server targets.
Changes:
- Removes configurable endpoint limits.
- Caps and sorts Geode locator targets.
- Updates truncation and validation tests.
File summaries
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
laurit
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the database server target cap a fixed five endpoints across all callers.
Remove
DbServerTargetBuilder.setMaxEndpoints(int), apply the fixed cap to Geode locator targets, and update coverage for sorted truncation and validation beyond the cap.