{{ message }}
Repository navigation
Report Spymemcached logical server in stable telemetry - #19838
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Captures Spymemcached clients’ configured server targets for stable database telemetry while preserving legacy handling-node behavior.
Changes:
- Captures immutable single- and multi-node targets at connection creation.
- Uses configured targets for stable span names, attributes, and metrics.
- Adds unit and integration coverage across semantic-convention modes.
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
settings.gradle.kts |
Registers the unit-test module. |
SpymemcachedTest.java |
Adds configured-target integration coverage. |
SpymemcachedSingletons.java |
Registers the new server extractor. |
SpymemcachedServerTargets.java |
Associates targets with connections. |
SpymemcachedServerTarget.java |
Validates and renders targets. |
SpymemcachedServerAttributesExtractor.java |
Preserves legacy fallback behavior. |
SpymemcachedRequest.java |
Snapshots the configured target. |
SpymemcachedInstrumentationModule.java |
Registers factory instrumentation. |
SpymemcachedAttributesGetter.java |
Exposes stable server attributes. |
ConnectionFactoryInstrumentation.java |
Captures configured node lists. |
SpymemcachedServerTargetTest.java |
Tests target rendering and validation. |
SpymemcachedRequestTest.java |
Tests request target propagation. |
SpymemcachedAttributesGetterTest.java |
Tests semantic-convention attributes. |
javaagent-unit-tests/build.gradle.kts |
Configures isolated semconv tests. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
trask
changed the title
trask
changed the title
trask
changed the title
trask
force-pushed
the
trask-spymemcached-configured-targets
branch
from
September 3, 2026 16:26
537cfa3 to
6f2e908
Compare
An error occurred while trying to automatically change base from
trask-database-endpoint-utility
to
main
September 3, 2026 17:32
Capture each client's configured server list and use it for stable database server attributes while preserving legacy handling-node behavior. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Keep complete normalized endpoints from the front of the configured target while capping server.address at 255 characters. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
trask
force-pushed
the
trask-spymemcached-configured-targets
branch
from
September 3, 2026 20:25
6f2e908 to
b8cfeeb
Compare
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
laurit
approved these changes
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is part of #19899 and applies the configured database target rules proposed in open-telemetry/semantic-conventions#4058 to Spymemcached. Stable spans,
db.client.operation.durationmetrics, and stable span names report the client's configured direct-node list as the logical target. Legacy telemetry continues to report the selected handling node inserver.addressandserver.port, and #19850 adds handling nodes asnetwork.peer.*.Multi-endpoint handling
server.addressserver.portcache-a:11211,cache-b:11211cache-a,cache-bcache-a:11212,cache-b:11212cache-a:11212,cache-b:11212cache-a:11211,cache-b:11212cache-a:11211,cache-b:11212Configured order and duplicate nodes are preserved. Stable telemetry validates every member of the configured list and then includes at most the first five endpoints.