iframe-proxy

danielroe · 2026-09-19T07:10:20Z

🔗 Linked issue

📚 Description

this drops a couple of unneeded deps - unctx brings in an extra 1 KB which isn't needed in the browser, where there is no AsyncLocalStorage... and defu was being used even when there was only one app.config - an unnecessary call

coldtea-pr-lens · 2026-09-19T07:10:24Z

◈ PR Lens

🟢 +0 new · 🟠 ~3 changed · 🔴 -0 removed · 1 flow · 6 files · commit 2f31569

Architecture

3 components touched across 2 lanes.

Open the interactive canvas

Data flow

Client app context resolution

Open the interactive canvas

View

Architecture lens
Data flow lens
Expand every detail

Tip

Switch GitHub to dark mode and the diagrams follow. The moving dots are this pull request's data in motion.

🪧 More tips

Run npx skills add coldteadotai/pr-lens, then tell your coding agent: "Diagram the change you just made with PR Lens and attach it to the pull request."
Run npx @coldtea/pr-lens-cli analyze --base origin/main on a branch, then npx @coldtea/pr-lens-cli render .pr-lens/graph.json. Same lenses, your own model key, before the pull request exists.
Untick Architecture lens or Data flow lens under View to hide a diagram, or tick Expand every detail to open every section. The comment redraws in a few seconds.
Click the link under each diagram to open it on a canvas you can zoom, pan and step through.
The diagrams are links. Click one to open it on the canvas, then press W or click play to walk through the change.
Open a diagram on the canvas, then press W or click play to walk through the change one step at a time.
The CLI's render reads .github/pr-lens.yml and applies your renames, exclusions and lane pins at draw time.
Set github.comment.collapsed: true in .github/pr-lens.yml to fold the comment behind one View architecture and data flow row. Drawing still runs on every push.
Add .github/workflows/pr-lens.yml with coldteadotai/pr-lens/packages/action@v0 and your model provider's key as its api-key to run PR Lens from your own CI. Any /chat/completions endpoint works.
Push a commit and the comment redraws for the new head. A slow older run never overwrites a newer one.

Thanks for using PR Lens! It's built by Coldtea, free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

pkg-pr-new · 2026-09-19T07:11:34Z

Open in StackBlitz

@nuxt/kit

pnpm add https://pkg.pr.new/nuxt/nuxt/@nuxt/kit@36371

npm i https://pkg.pr.new/nuxt/nuxt/@nuxt/kit@36371

yarn add https://pkg.pr.new/nuxt/nuxt/@nuxt/kit@36371.tgz

@nuxt/nitro-server

pnpm add https://pkg.pr.new/nuxt/nuxt/@nuxt/nitro-server@36371

npm i https://pkg.pr.new/nuxt/nuxt/@nuxt/nitro-server@36371

yarn add https://pkg.pr.new/nuxt/nuxt/@nuxt/nitro-server@36371.tgz

nuxt

pnpm add https://pkg.pr.new/nuxt/nuxt@36371

npm i https://pkg.pr.new/nuxt/nuxt@36371

yarn add https://pkg.pr.new/nuxt/nuxt@36371.tgz

@nuxt/rspack-builder

pnpm add https://pkg.pr.new/nuxt/nuxt/@nuxt/rspack-builder@36371

npm i https://pkg.pr.new/nuxt/nuxt/@nuxt/rspack-builder@36371

yarn add https://pkg.pr.new/nuxt/nuxt/@nuxt/rspack-builder@36371.tgz

@nuxt/schema

pnpm add https://pkg.pr.new/nuxt/nuxt/@nuxt/schema@36371

npm i https://pkg.pr.new/nuxt/nuxt/@nuxt/schema@36371

yarn add https://pkg.pr.new/nuxt/nuxt/@nuxt/schema@36371.tgz

@nuxt/vite-builder

pnpm add https://pkg.pr.new/nuxt/nuxt/@nuxt/vite-builder@36371

npm i https://pkg.pr.new/nuxt/nuxt/@nuxt/vite-builder@36371

yarn add https://pkg.pr.new/nuxt/nuxt/@nuxt/vite-builder@36371.tgz

@nuxt/vite-server

pnpm add https://pkg.pr.new/nuxt/nuxt/@nuxt/vite-server@36371

npm i https://pkg.pr.new/nuxt/nuxt/@nuxt/vite-server@36371

yarn add https://pkg.pr.new/nuxt/nuxt/@nuxt/vite-server@36371.tgz

@nuxt/webpack-builder

pnpm add https://pkg.pr.new/nuxt/nuxt/@nuxt/webpack-builder@36371

npm i https://pkg.pr.new/nuxt/nuxt/@nuxt/webpack-builder@36371

yarn add https://pkg.pr.new/nuxt/nuxt/@nuxt/webpack-builder@36371.tgz

commit: 2f31569

coderabbitai · 2026-09-19T07:15:52Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Advanced

Run ID: 0f4589b3-6d4b-40d2-967a-882fddd7711c

📥 Commits

Reviewing files that changed from the base of the PR and between bef2789 and 2f31569.

📒 Files selected for processing (6)

packages/nuxt/src/app/internal/context.ts
packages/nuxt/src/app/nuxt.ts
packages/nuxt/src/core/nuxt.ts
packages/nuxt/src/core/templates.ts
packages/nuxt/test/templates.test.ts
test/bundle.test.ts

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

Walkthrough

The change adds a Nuxt context wrapper with client-side singleton contexts and server-side unctx fallback. Nuxt uses the local wrapper, and the transform plugin runs only in server builds. App configuration output omits defuFn when no config layers exist. Tests and bundle snapshots cover the updated output and sizes.

Priority: ⬇️ Low

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 25.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 6 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Fix all pre-merge checks with AI

✨ Finishing Touches 💡 1

📝 Generate docstrings 💡

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

…object config) (#36371) (cherry picked from commit 1b227df)

### 🔗 Linked issue  * resolves #1138 ### 📚 Description   Nuxt 4.6.0 changed where it stores the browser instance, moving it from `unctx` to `globalThis.__nuxt_app_ctx__` (nuxt/nuxt#36371). Since this addon was still registering the instance directly through `unctx`, `useNuxtApp()` fails to pick it up on 4.6.x and throws `NUXT_E1001`, which breaks existing stories. To fix this, we switch to `getNuxtAppCtx` from `#app/nuxt` so it points to the correct store regardless of the Nuxt version. I've also removed the `unctx` dependency since it's no longer needed. For testing, I packed the addon and ran `storybook build` against a minimal Nuxt 4.6.1 setup with a story using `useNuxtApp()`. It threw `NUXT_E1001` before the fix, but now builds cleanly without any console errors. I also verified that the playground still builds and works fine on Nuxt 4.4.8, and all unit tests pass.

* resolves #1138   Nuxt 4.6.0 changed where it stores the browser instance, moving it from `unctx` to `globalThis.__nuxt_app_ctx__` (nuxt/nuxt#36371). Since this addon was still registering the instance directly through `unctx`, `useNuxtApp()` fails to pick it up on 4.6.x and throws `NUXT_E1001`, which breaks existing stories. To fix this, we switch to `getNuxtAppCtx` from `#app/nuxt` so it points to the correct store regardless of the Nuxt version. I've also removed the `unctx` dependency since it's no longer needed. For testing, I packed the addon and ran `storybook build` against a minimal Nuxt 4.6.1 setup with a story using `useNuxtApp()`. It threw `NUXT_E1001` before the fix, but now builds cleanly without any console errors. I also verified that the playground still builds and works fine on Nuxt 4.4.8, and all unit tests pass. (cherry picked from commit f04a310)

danielroe added 2 commits September 19, 2026 08:07

perf(nuxt): do not ship unctx to the client bundle

0f5357e

perf(nuxt): do not use defu unnecessarily to merge app config

2f31569

github-actions Bot added 5.x ⚡ performance Performance degradation or optimization opportunity labels Sep 19, 2026

danielroe added this pull request to the merge queue Sep 19, 2026

Merged via the queue into main with commit 1b227df Sep 19, 2026
39 checks passed

danielroe deleted the perf/drop-client-deps branch September 19, 2026 08:06

github-actions Bot mentioned this pull request Sep 18, 2026

v5.0.0-1 #36168

Draft

danielroe added a commit that referenced this pull request Sep 23, 2026

perf(nuxt): drop unctx from client environment (+ defu in single-…

af9ed08

…object config) (#36371) (cherry picked from commit 1b227df)

github-actions Bot mentioned this pull request Sep 17, 2026

v4.6.0 #36184

Merged

danielroe added a commit that referenced this pull request Sep 23, 2026

perf(nuxt): drop unctx from client environment (+ defu in single-…

aed0052

…object config) (#36371) (cherry picked from commit 1b227df)

danielroe added a commit that referenced this pull request Sep 23, 2026

perf(nuxt): drop unctx from client environment (+ defu in single-…

bd6cb27

…object config) (#36371) (cherry picked from commit 1b227df)

github-actions Bot mentioned this pull request Oct 5, 2026

v4.6.0 #36465

Merged

This was referenced Oct 13, 2026

All stories fail with NUXT_E1001 on Nuxt 4.6 because preview registers the Nuxt instance in unctx nuxt-modules/storybook#1138

Closed

fix(addon): use Nuxt's app context for Nuxt 4.6 compatibility nuxt-modules/storybook#1139

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

perf(nuxt): drop `unctx` from client environment (+ `defu` in single-object config) - #36371

perf(nuxt): drop `unctx` from client environment (+ `defu` in single-object config)#36371
danielroe merged 2 commits into
mainfrom
perf/drop-client-deps

danielroe commented Sep 19, 2026

Uh oh!

coldtea-pr-lens Bot commented Sep 19, 2026 •

edited

Loading

Uh oh!

pkg-pr-new Bot commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

danielroe commented Sep 19, 2026

🔗 Linked issue

📚 Description

Uh oh!

coldtea-pr-lens Bot commented Sep 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

◈ PR Lens

Uh oh!

pkg-pr-new Bot commented Sep 19, 2026

Uh oh!

coderabbitai Bot commented Sep 19, 2026

Walkthrough

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coldtea-pr-lens Bot commented Sep 19, 2026 •

edited

Loading