perf(kit): drop `ufo` dependency by danielroe · Pull Request #36073 · nuxt/nuxt · GitHub
Skip to content

perf(kit): drop ufo dependency - #36073

Merged
danielroe merged 1 commit into
mainfrom
perf/kit-ufo
Aug 14, 2026
Merged

danielroe merged 1 commit into
mainfrom
perf/kit-ufo

Conversation

@danielroe

Copy link
Copy Markdown
Member

🔗 Linked issue

📚 Description

another kit perf improvement - this drops ufo which was being wrongly used - it's a URL lib but was being used for file path arithmetic 🤦

@github-actions github-actions Bot added 5.x ⚡ performance Performance degradation or optimization opportunity labels Aug 14, 2026
@pkg-pr-new

pkg-pr-new Bot commented Aug 14, 2026

Copy link
Copy Markdown

@danielroe
danielroe enabled auto-merge August 14, 2026 12:34
@coderabbitai

coderabbitai Bot commented Aug 14, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 47ed2539-2acb-476b-bf42-4af985e23447

📥 Commits

Reviewing files that changed from the base of the PR and between 75ed8ed and 5da5e21.

⛔ Files ignored due to path filters (2)
  • packages/kit/package.json is excluded by !**/package.json
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml, !pnpm-lock.yaml
📒 Files selected for processing (4)
  • packages/kit/src/internal/node-module.ts
  • packages/kit/src/loader/config.ts
  • packages/kit/src/module/install.ts
  • packages/kit/src/resolve.test.ts

Walkthrough

The changes remove selected joinURL and ufo helper usage. Export subpaths now use explicit slash handling. Layer path normalisation uses regular expressions and a local withTrailingSlash helper. Relative module paths use direct prefix checks. The resolver test removes its helper import and applies inline trailing-slash removal.

Merge Risk: ⚪ Minimal · up to 5da5e

This localized dependency removal introduces no concrete correctness, runtime, deployment, or availability risk in the supplied evidence and is merge-ready after normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely states that the pull request removes the ufo dependency from kit.
Description check ✅ Passed The description directly explains the removal of ufo from kit and the reason for the change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch perf/kit-ufo

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codspeed

codspeed Bot commented Aug 14, 2026

Copy link
Copy Markdown

@danielroe
danielroe added this pull request to the merge queue Aug 14, 2026
Merged via the queue into main with commit 262cc54 Aug 14, 2026
59 of 61 checks passed
@danielroe
danielroe deleted the perf/kit-ufo branch August 14, 2026 13:33
@github-actions github-actions Bot mentioned this pull request Aug 14, 2026
2 of 5 tasks
danielroe added a commit that referenced this pull request Aug 14, 2026
@github-actions github-actions Bot mentioned this pull request Aug 14, 2026
danielroe added a commit that referenced this pull request Aug 14, 2026
This was referenced Aug 25, 2026
@github-actions github-actions Bot mentioned this pull request Oct 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

5.x ⚡ performance Performance degradation or optimization opportunity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant