{{ message }}
BUG: NpyString comparison should use memcmp instead of strncmp - #31662
Merged
Merged
Conversation
ngoldbaum
added
00 - Bug
09 - Backport-Candidate
seberg
approved these changes
Jun 17, 2026
Member
There was a problem hiding this comment.
Suggested change
| StringDType comparisons now correctly handle embedded NULL bytes. | |
| * StringDType comparisons now correctly handle embedded NULL bytes. |
I know, I know...
Member
There was a problem hiding this comment.
Honestly, I would just use a clearly large enough size "S20" or so. (but also fine without)
charris
pushed a commit
that referenced
this pull request
Jun 18, 2026
charris
added a commit
that referenced
this pull request
Jun 18, 2026
BUG: NpyString comparison should use memcmp instead of strncmp (#31662)
ngoldbaum
added a commit
to ngoldbaum/numpy
that referenced
this pull request
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
strncmp compares C strings, and stops comparisons after hitting an embedded null. We should be using memcmp for our strings, which can contain embedded nulls.
Fixes that and adds tests for comparisons and conversions
I used AI assistance to identify and help fix the bug.
Ping @mhvk since you were involved with the design here. C is hard!