{{ message }}
fix: Fix server closing in tests.#3279
Merged
Merged
Conversation
mcollina
reviewed
May 20, 2024
Merged
This was referenced Jul 8, 2024
This was referenced Jul 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
nodejs/node#53028
Rationale
When running in 18.20.3, the test suite fails to stop the test as the HTTP server does not close if some connections are still pending.
Changes
This PR changes the test utils to close pending connection first before closing the server. This is already the default behavior in Node 20+.
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status