feat: add support for SharedArrayBuffer in TypedArray and TypedArrayOf by KevinEady · Pull Request #1731 · nodejs/node-addon-api · GitHub
Skip to content

feat: add support for SharedArrayBuffer in TypedArray and TypedArrayOf#1731

Merged
legendecas merged 1 commit into
nodejs:mainfrom
KevinEady:support-sharedarraybuffer-in-typedarray
May 24, 2026
Merged

feat: add support for SharedArrayBuffer in TypedArray and TypedArrayOf#1731
legendecas merged 1 commit into
nodejs:mainfrom
KevinEady:support-sharedarraybuffer-in-typedarray

Conversation

@KevinEady

@KevinEady KevinEady commented May 21, 2026

Copy link
Copy Markdown
Contributor

Add support for SharedArrayBuffer in TypedArray and TypedArrayOf<T>.

Fixes: #1730

@codecov-commenter

codecov-commenter commented May 21, 2026

Copy link
Copy Markdown

@KevinEady KevinEady force-pushed the support-sharedarraybuffer-in-typedarray branch from 3de1889 to 09557a9 Compare May 22, 2026 08:32
Comment thread test/typedarray.js

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this error is only expected on binding.typedarray.createInt8TypedArrayFromSharedArrayBuffer. Could this try...catch scope be limited to this single call instead?

@legendecas legendecas moved this from Need Triage to In Progress in Node-API Team Project May 22, 2026
@KevinEady KevinEady force-pushed the support-sharedarraybuffer-in-typedarray branch from 09557a9 to b247aa8 Compare May 22, 2026 17:31
@legendecas legendecas merged commit 00b95ef into nodejs:main May 24, 2026
105 of 108 checks passed
@github-project-automation github-project-automation Bot moved this from In Progress to Done in Node-API Team Project May 24, 2026
@github-actions github-actions Bot mentioned this pull request May 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add SharedArrayBuffer support in Napi::TypedArray

3 participants