{{ message }}
Repository navigation
Conversation
Signed-off-by: cuishuang <imcusg@gmail.com>
nodejs-github-bot
added
fs
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65882 +/- ##
==========================================
- Coverage 90.19% 90.18% -0.01%
==========================================
Files 771 771
Lines 264911 265094 +183
Branches 50323 50351 +28
==========================================
+ Hits 238939 239082 +143
- Misses 16922 16963 +41
+ Partials 9050 9049 -1
🚀 New features to boost your workflow:
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the JavaScript recursive watcher is used, removing a watched root file emits an empty filename.
This happens because the deletion path uses the root-relative filename, and the relative path of the root file to itself is empty. The same watcher emits the basename for change events, while native recursive watchers also report the basename.
Emit the basename in the root-file deletion branch to keep the result consistent with change events and native recursive watchers.
Tests:
Refs: #65486