{{ message }}
test: avoid test_runner watch restart in spec snapshot#63392
Merged
nodejs-github-bot merged 1 commit intoMay 24, 2026
Merged
Conversation
Pass explicit test files to the watch-mode spec reporter fixture. This prevents setup writes from triggering a watch restart. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
nodejs-github-bot
added
needs-ci
aduh95
approved these changes
May 18, 2026
github-actions
Bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
Collaborator
trivikr
added
the
author ready
aduh95
added
the
flaky-test
trivikr
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
araujogui
pushed a commit
to araujogui/node
that referenced
this pull request
May 26, 2026
Pass explicit test files to the watch-mode spec reporter fixture. This prevents setup writes from triggering a watch restart. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63392 Refs: https://github.com/nodejs/node/actions/runs/25983032903/job/76375266688 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 27, 2026
Pass explicit test files to the watch-mode spec reporter fixture. This prevents setup writes from triggering a watch restart. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63392 Refs: https://github.com/nodejs/node/actions/runs/25983032903/job/76375266688 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sxa
pushed a commit
to sxa/node
that referenced
this pull request
Jun 18, 2026
Pass explicit test files to the watch-mode spec reporter fixture. This prevents setup writes from triggering a watch restart. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: nodejs#63392 Refs: https://github.com/nodejs/node/actions/runs/25983032903/job/76375266688 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
sxa
pushed a commit
that referenced
this pull request
Jun 18, 2026
Pass explicit test files to the watch-mode spec reporter fixture. This prevents setup writes from triggering a watch restart. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5 PR-URL: #63392 Refs: https://github.com/nodejs/node/actions/runs/25983032903/job/76375266688 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
test_runnerwatch-mode spec reporter fixture to passexplicit test files to
run().The fixture no longer watches the whole temporary directory, so setup writes
cannot race with watcher initialization and emit an unexpected restart banner.
Refs:
Assisted-by: openai:gpt-5.5