iframe-proxy

araujogui · 2026-04-28T00:33:08Z

Improve styleText performance by caching and fast-path

Benchmark

util/style-text.js n=1000 validateStream=0 format='#ff0000' messageType='boolean'                -0.71 %       ±1.04%  ±1.38%  ±1.80%
util/style-text.js n=1000 validateStream=0 format='#ff0000' messageType='invalid'                 0.80 %       ±0.86%  ±1.14%  ±1.49%
util/style-text.js n=1000 validateStream=0 format='#ff0000' messageType='number'                 -0.59 %       ±0.93%  ±1.24%  ±1.62%
util/style-text.js n=1000 validateStream=0 format='#ff0000' messageType='string'         ***   1135.88 %      ±31.19% ±42.04% ±55.81%
util/style-text.js n=1000 validateStream=0 format='invalid' messageType='boolean'                -0.09 %       ±1.43%  ±1.90%  ±2.47%
util/style-text.js n=1000 validateStream=0 format='invalid' messageType='invalid'                -0.02 %       ±0.98%  ±1.30%  ±1.69%
util/style-text.js n=1000 validateStream=0 format='invalid' messageType='number'                  0.83 %       ±1.79%  ±2.40%  ±3.15%
util/style-text.js n=1000 validateStream=0 format='invalid' messageType='string'           *     -1.19 %       ±0.97%  ±1.29%  ±1.68%
util/style-text.js n=1000 validateStream=0 format='italic' messageType='boolean'                 -0.24 %       ±1.16%  ±1.55%  ±2.02%
util/style-text.js n=1000 validateStream=0 format='italic' messageType='invalid'                  0.60 %       ±0.92%  ±1.23%  ±1.60%
util/style-text.js n=1000 validateStream=0 format='italic' messageType='number'                   0.81 %       ±1.22%  ±1.63%  ±2.14%
util/style-text.js n=1000 validateStream=0 format='italic' messageType='string'                   1.47 %       ±3.09%  ±4.12%  ±5.36%
util/style-text.js n=1000 validateStream=0 format='red' messageType='boolean'              *      1.17 %       ±1.03%  ±1.37%  ±1.79%
util/style-text.js n=1000 validateStream=0 format='red' messageType='invalid'                     0.73 %       ±0.99%  ±1.32%  ±1.72%
util/style-text.js n=1000 validateStream=0 format='red' messageType='number'                     -0.34 %       ±0.94%  ±1.25%  ±1.63%
util/style-text.js n=1000 validateStream=0 format='red' messageType='string'                      4.92 %       ±6.11%  ±8.17% ±10.72%
util/style-text.js n=1000 validateStream=1 format='#ff0000' messageType='boolean'                -0.50 %       ±1.32%  ±1.76%  ±2.29%
util/style-text.js n=1000 validateStream=1 format='#ff0000' messageType='invalid'                 0.62 %       ±0.89%  ±1.19%  ±1.56%
util/style-text.js n=1000 validateStream=1 format='#ff0000' messageType='number'                 -0.14 %       ±0.79%  ±1.06%  ±1.37%
util/style-text.js n=1000 validateStream=1 format='#ff0000' messageType='string'                 -0.27 %       ±1.23%  ±1.64%  ±2.14%
util/style-text.js n=1000 validateStream=1 format='invalid' messageType='boolean'                -0.31 %       ±0.97%  ±1.29%  ±1.68%
util/style-text.js n=1000 validateStream=1 format='invalid' messageType='invalid'                 0.61 %       ±0.85%  ±1.13%  ±1.48%
util/style-text.js n=1000 validateStream=1 format='invalid' messageType='number'                 -0.05 %       ±0.78%  ±1.04%  ±1.35%
util/style-text.js n=1000 validateStream=1 format='invalid' messageType='string'                  0.69 %       ±1.55%  ±2.07%  ±2.70%
util/style-text.js n=1000 validateStream=1 format='italic' messageType='boolean'                 -0.01 %       ±1.07%  ±1.42%  ±1.85%
util/style-text.js n=1000 validateStream=1 format='italic' messageType='invalid'                 -0.27 %       ±1.09%  ±1.45%  ±1.90%
util/style-text.js n=1000 validateStream=1 format='italic' messageType='number'                   0.04 %       ±1.04%  ±1.38%  ±1.80%
util/style-text.js n=1000 validateStream=1 format='italic' messageType='string'                  -0.41 %       ±0.91%  ±1.21%  ±1.58%
util/style-text.js n=1000 validateStream=1 format='red' messageType='boolean'                     0.56 %       ±1.18%  ±1.57%  ±2.05%
util/style-text.js n=1000 validateStream=1 format='red' messageType='invalid'                    -0.41 %       ±0.94%  ±1.26%  ±1.64%
util/style-text.js n=1000 validateStream=1 format='red' messageType='number'                     -0.88 %       ±0.96%  ±1.28%  ±1.67%
util/style-text.js n=1000 validateStream=1 format='red' messageType='string'                     -0.04 %       ±1.00%  ±1.33%  ±1.73%

Copilot

Pull request overview

This PR improves util.styleText() performance for hex colors by introducing a cached hex-style lookup and a fast path for the common case where validateStream: false.

Changes:

Add a module-level hexStyleCache and helper (getHexStyle) to memoize computed ANSI sequences for #RGB/#RRGGBB.
Reuse a shared close sequence constant for 24-bit foreground colors (\u001b[39m) and integrate hex handling into the validateStream: false fast path.
Refactor hex handling in the main formatting loop to use cached sequences instead of re-parsing on every call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov · 2026-04-28T01:59:50Z

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

araujogui · 2026-05-09T03:20:56Z

CC @nodejs/performance

gurgunday

This cache will grow indefinitely

I don't think we should land like this

gurgunday

code lgtm

note: i am unfamiliar with how much this is used

mcollina

lgtm

nodejs-github-bot · 2026-05-27T18:14:09Z

CI: https://ci.nodejs.org/job/node-test-pull-request/73789/
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1862/

nodejs-github-bot · 2026-05-29T19:43:36Z

Landed in 6f29e1a

TheOneTheOnlyJJ · 2026-05-30T14:33:04Z

+
 let styleCache;

+const kHexStyleCacheMax = 256;


Should this be open to user configuration?

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62999 Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: nodejs#62999 Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com> PR-URL: #62999 Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

Copilot AI review requested due to automatic review settings April 28, 2026 00:33

nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Apr 28, 2026

Copilot started reviewing on behalf of araujogui April 28, 2026 00:33 View session

Copilot AI reviewed Apr 28, 2026

View reviewed changes

Comment thread lib/util.js Outdated

Comment thread lib/util.js Outdated

Renegade334 reviewed Apr 29, 2026

View reviewed changes

Comment thread lib/util.js Outdated

araujogui force-pushed the improve-styletext branch from c879174 to 521eba3 Compare May 8, 2026 22:46

araujogui added 3 commits May 8, 2026 21:08

util: create hex style cache and fast path

512ce5b

Signed-off-by: Guilherme Araújo <arauujogui@gmail.com>

util: skip getHexStyle() when colorization is disabled

bcf6f74

benchmark: create rotating hex benchmark

5b9ea9d

araujogui force-pushed the improve-styletext branch from 521eba3 to 5b9ea9d Compare May 9, 2026 00:08

gurgunday requested changes May 9, 2026

View reviewed changes

Comment thread lib/util.js Outdated

Comment thread lib/util.js Outdated

util: implement fifo cache with safemap

f4f71de

araujogui force-pushed the improve-styletext branch from 49fe099 to f4f71de Compare May 9, 2026 14:34

araujogui requested a review from gurgunday May 9, 2026 14:38

gurgunday approved these changes May 10, 2026

View reviewed changes

mcollina reviewed May 11, 2026

View reviewed changes

Comment thread lib/util.js Outdated

util: remove class

4e16425

araujogui requested a review from mcollina May 11, 2026 13:31

mcollina approved these changes May 11, 2026

View reviewed changes

atlowChemi added the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2026

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label May 27, 2026

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 27, 2026

Ethan-Arrowood approved these changes May 27, 2026

View reviewed changes

addaleax added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels May 29, 2026

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label May 29, 2026

nodejs-github-bot merged commit 6f29e1a into nodejs:main May 29, 2026
80 checks passed

TheOneTheOnlyJJ reviewed May 30, 2026

View reviewed changes

github-actions Bot mentioned this pull request May 30, 2026

2026-06-01, Version 26.3.0 (Current) #63664

Merged

github-actions Bot mentioned this pull request Jun 19, 2026

2026-06-19, Version 24.18.0 'Krypton' (LTS) #64001

Closed

sxa mentioned this pull request Jun 22, 2026

2026-06-23, Version 24.18.0 'Krypton' (LTS) #64062

Merged

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Uh oh!

Conversation

araujogui commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

codecov Bot commented Apr 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

araujogui commented May 9, 2026

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

gurgunday left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented May 27, 2026 • edited by aduh95 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

nodejs-github-bot commented May 29, 2026

Uh oh!

TheOneTheOnlyJJ May 30, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

araujogui commented Apr 28, 2026 •

edited

Loading

codecov Bot commented Apr 28, 2026 •

edited

Loading

nodejs-github-bot commented May 27, 2026 •

edited by aduh95

Loading