lib: use bracket notation instead of `String.prototype.startWith` for locks by kimtaejin3 · Pull Request #61492 · nodejs/node · GitHub
Skip to content

lib: use bracket notation instead of String.prototype.startWith for locks#61492

Merged
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
kimtaejin3:lib/prefer-primordials-in-locks
Jan 29, 2026
Merged

lib: use bracket notation instead of String.prototype.startWith for locks#61492
nodejs-github-bot merged 3 commits into
nodejs:mainfrom
kimtaejin3:lib/prefer-primordials-in-locks

Conversation

@kimtaejin3

@kimtaejin3 kimtaejin3 commented Jan 23, 2026

Copy link
Copy Markdown
Contributor

Use StringPrototypeStartsWith from primordials instead of String.prototype.startsWith to prevent prototype pollution.

@kimtaejin3
lib: use StringPrototypeStartsWith from primordials in locks
16ead22 
Use StringPrototypeStartsWith from primordials instead of
String.prototype.startsWith to prevent prototype pollution.

Refs: nodejs#59699
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jan 23, 2026
@codecov

codecov Bot commented Jan 23, 2026 •
edited
Loading

Copy link
Copy Markdown

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jan 23, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 23, 2026
@nodejs-github-bot

nodejs-github-bot commented Jan 23, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/70984/

ljharb
ljharb reviewed Jan 23, 2026
View reviewed changes
Comment thread lib/internal/locks.js Outdated
@nodejs-github-bot

nodejs-github-bot commented Jan 24, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71005/

@kimtaejin3 @ljharb
Apply suggestions from code review
7176d5a 
Co-authored-by: Jordan Harband <ljharb@gmail.com>
@kimtaejin3 kimtaejin3 changed the title lib: use StringPrototypeStartsWith from primordials in locks lib: use bracket notation instead of String.prototype.startWith in locks Jan 24, 2026
@kimtaejin3 kimtaejin3 changed the title lib: use bracket notation instead of String.prototype.startWith in locks lib: use bracket notation instead of String.prototype.startWith for locks Jan 24, 2026
gurgunday
gurgunday reviewed Jan 26, 2026
View reviewed changes
Comment thread lib/internal/locks.js Outdated
@kimtaejin3 @gurgunday
Update lib/internal/locks.js
bf9e8e8 
Co-authored-by: Gürgün Dayıoğlu <hey@gurgun.day>
@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71059/

@nodejs-github-bot

nodejs-github-bot commented Jan 27, 2026

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/71080/

@gurgunday gurgunday added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Jan 29, 2026
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 29, 2026
@nodejs-github-bot nodejs-github-bot merged commit 784ca7b into nodejs:main Jan 29, 2026
66 of 69 checks passed
@nodejs-github-bot

nodejs-github-bot commented Jan 29, 2026

Copy link
Copy Markdown
Collaborator

aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@kimtaejin3 @aduh95
lib: use StringPrototypeStartsWith from primordials in locks
828146e 
Use StringPrototypeStartsWith from primordials instead of
String.prototype.startsWith to prevent prototype pollution.

Refs: #59699
PR-URL: #61492
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actions github-actions Bot mentioned this pull request Feb 2, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 2, 2026
@kimtaejin3 @aduh95
lib: use StringPrototypeStartsWith from primordials in locks
44b1927 
Use StringPrototypeStartsWith from primordials instead of
String.prototype.startsWith to prevent prototype pollution.

Refs: #59699
PR-URL: #61492
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit that referenced this pull request Feb 10, 2026
@kimtaejin3 @aduh95
lib: use StringPrototypeStartsWith from primordials in locks
85ea3c2 
Use StringPrototypeStartsWith from primordials instead of
String.prototype.startsWith to prevent prototype pollution.

Refs: #59699
PR-URL: #61492
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
aduh95 pushed a commit that referenced this pull request Feb 14, 2026
@kimtaejin3 @aduh95
lib: use StringPrototypeStartsWith from primordials in locks
60d74d5 
Use StringPrototypeStartsWith from primordials instead of
String.prototype.startsWith to prevent prototype pollution.

Refs: #59699
PR-URL: #61492
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
@github-actions github-actions Bot mentioned this pull request Feb 22, 2026
Merged
aduh95 pushed a commit that referenced this pull request Feb 22, 2026
@kimtaejin3 @aduh95
lib: use StringPrototypeStartsWith from primordials in locks
069874b 
Use StringPrototypeStartsWith from primordials instead of
String.prototype.startsWith to prevent prototype pollution.

Refs: #59699
PR-URL: #61492
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb left review comments
@cjihrig cjihrig cjihrig approved these changes
@aduh95 aduh95 aduh95 approved these changes
@gurgunday gurgunday gurgunday approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kimtaejin3 @nodejs-github-bot @ljharb @cjihrig @aduh95 @gurgunday