build,test: add tests for binary linked with shared libnode by joyeecheung · Pull Request #61463 · nodejs/node · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 55 additions & 0 deletions node.gyp
11 changes: 11 additions & 0 deletions test/common/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,8 @@ if (isMainThread)

const noop = () => {};

// Whether the executable is linked against the shared library i.e. libnode.
const usesSharedLibrary = process.config.variables.node_shared;
const hasCrypto = Boolean(process.versions.openssl) &&
!process.env.NODE_SKIP_CRYPTO;

Expand Down Expand Up @@ -950,6 +952,13 @@ function sleepSync(ms) {
Atomics.wait(i32, 0, 0, ms);
}

function resolveBuiltBinary(binary) {
if (isWindows) {
binary += '.exe';
}
return path.join(path.dirname(process.execPath), binary);
}

const common = {
allowGlobals,
buildType,
Expand Down Expand Up @@ -995,6 +1004,7 @@ const common = {
printSkipMessage,
pwdCommand,
requireNoPackageJSONAbove,
resolveBuiltBinary,
runWithInvalidFD,
skip,
skipIf32Bits,
Expand All @@ -1003,6 +1013,7 @@ const common = {
skipIfSQLiteMissing,
spawnPromisified,
sleepSync,
usesSharedLibrary,

get enoughTestMem() {
return require('os').totalmem() > 0x70000000; /* 1.75 Gb */
Expand Down
60 changes: 60 additions & 0 deletions test/embedding/shared_embedtest.cc
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
#include <libplatform/libplatform.h>
#include <v8-cppgc.h>
#include <v8.h>

#include <cppgc/allocation.h>
#include <cppgc/default-platform.h>
#include <cppgc/garbage-collected.h>
#include <cppgc/heap.h>
#include <cppgc/member.h>
#include <cppgc/platform.h>
#include <cppgc/visitor.h>

class Wrappable : public v8::Object::Wrappable {
public:
void Trace(cppgc::Visitor* visitor) const override {
v8::Object::Wrappable::Trace(visitor);
}
};

int main(int argc, char* argv[]) {
std::unique_ptr<v8::Platform> platform = v8::platform::NewDefaultPlatform();
v8::V8::InitializePlatform(platform.get());
cppgc::InitializeProcess(platform->GetPageAllocator());
v8::V8::Initialize();

auto heap = v8::CppHeap::Create(platform.get(), v8::CppHeapCreateParams{{}});
v8::Isolate::CreateParams create_params;
create_params.array_buffer_allocator =
v8::ArrayBuffer::Allocator::NewDefaultAllocator();
create_params.cpp_heap = heap.release();

v8::Isolate* isolate = v8::Isolate::New(create_params);
{
v8::Isolate::Scope isolate_scope(isolate);
v8::HandleScope handle_scope(isolate);
v8::Local<v8::Context> context = v8::Context::New(isolate);
v8::Context::Scope context_scope(context);

v8::Local<v8::Object> obj = v8::Object::New(isolate);
Wrappable* wrappable = cppgc::MakeGarbageCollected<Wrappable>(
isolate->GetCppHeap()->GetAllocationHandle());
v8::Object::Wrap<v8::CppHeapPointerTag::kDefaultTag>(
isolate, obj, wrappable);
v8::Local<v8::String> source =
v8::String::NewFromUtf8Literal(isolate, "'Hello' + ', World!'");
v8::Local<v8::Script> script =
v8::Script::Compile(context, source).ToLocalChecked();
v8::Local<v8::Value> result = script->Run(context).ToLocalChecked();
v8::String::Utf8Value utf8(isolate, result);
printf("%s\n", *utf8);
}

isolate->Dispose();
cppgc::ShutdownProcess();
v8::V8::Dispose();
v8::V8::DisposePlatform();
delete create_params.array_buffer_allocator;

return 0;
}
10 changes: 1 addition & 9 deletions test/embedding/test-embedding.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,22 +8,14 @@ const {
spawnSyncAndExit,
spawnSyncAndExitWithoutError,
} = require('../common/child_process');
const path = require('path');
const fs = require('fs');
const os = require('os');

tmpdir.refresh();
common.allowGlobals(global.require);
common.allowGlobals(global.embedVars);

function resolveBuiltBinary(binary) {
if (common.isWindows) {
binary += '.exe';
}
return path.join(path.dirname(process.execPath), binary);
}

const binary = resolveBuiltBinary('embedtest');
const binary = common.resolveBuiltBinary('embedtest');

spawnSyncAndAssert(
binary,
Expand Down
25 changes: 25 additions & 0 deletions test/embedding/test-shared-embedding-v8.js
Loading