util: preserve `length` of deprecated functions by LiviaMedeiros · Pull Request #57806 · nodejs/node · GitHub
Skip to content

util: preserve length of deprecated functions#57806

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
LiviaMedeiros:util-deprecate-preserve-length
Apr 11, 2025
Merged

util: preserve length of deprecated functions#57806
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
LiviaMedeiros:util-deprecate-preserve-length

Conversation

@LiviaMedeiros

@LiviaMedeiros LiviaMedeiros commented Apr 9, 2025

Copy link
Copy Markdown
Member

More radical (and probably breaking some existing tests) solution would be wrapping original function in Proxy instead of separate deprecated() function.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Apr 9, 2025
ljharb
ljharb approved these changes Apr 9, 2025
View reviewed changes

@ljharb ljharb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

definitely shouldn't ever do a proxy :-) this is great tho

@codecov

codecov Bot commented Apr 9, 2025 •
edited
Loading

Copy link
Copy Markdown

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 9, 2025
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 9, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66171/

@nodejs-github-bot

nodejs-github-bot commented Apr 9, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66175/

@nodejs-github-bot

nodejs-github-bot commented Apr 10, 2025

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66180/

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 10, 2025
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 10, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 11, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2025

Copy link
Copy Markdown
Collaborator
Commit Queue failed
- Loading data for nodejs/node/pull/57806
✔  Done loading data for nodejs/node/pull/57806
----------------------------------- PR info ------------------------------------
Title      util: preserve `length` of deprecated functions (#57806)
Author     Livia Medeiros <livia@cirno.name> (@LiviaMedeiros)
Branch     LiviaMedeiros:util-deprecate-preserve-length -> nodejs:main
Labels     util, author ready, needs-ci
Commits    2
 - util: preserve `length` of deprecated functions
 - squash: mitigate prototype pollution
Committers 1
 - LiviaMedeiros <livia@cirno.name>
PR-URL: https://github.com/nodejs/node/pull/57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 09 Apr 2025 16:07:02 GMT
   ✔  Approvals: 6
   ✔  - Jordan Harband (@ljharb): https://github.com/nodejs/node/pull/57806#pullrequestreview-2754128591
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/57806#pullrequestreview-2757725368
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/57806#pullrequestreview-2758333132
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/57806#pullrequestreview-2758600034
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/57806#pullrequestreview-2758723356
   ✔  - Marco Ippolito (@marco-ippolito) (TSC): https://github.com/nodejs/node/pull/57806#pullrequestreview-2760421642
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-04-10T01:42:16Z: https://ci.nodejs.org/job/node-test-pull-request/66180/
- Querying data for job/node-test-pull-request/66180/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 57806
From https://github.com/nodejs/node
 * branch                  refs/pull/57806/merge -> FETCH_HEAD
✔  Fetched commits as 795dd8eb7988..782cee8be4a5
--------------------------------------------------------------------------------
[main 6a41eac7a6] util: preserve `length` of deprecated functions
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Wed Apr 9 23:46:59 2025 +0800
 2 files changed, 22 insertions(+)
[main 8da3941862] squash: mitigate prototype pollution
 Author: LiviaMedeiros <livia@cirno.name>
 Date: Thu Apr 10 00:42:57 2025 +0800
 1 file changed, 10 insertions(+), 2 deletions(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
util: preserve `length` of deprecated functions

PR-URL: #57806

Reviewed-By: Jordan Harband <ljharb@gmail.com>

Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Reviewed-By: James M Snell <jasnell@gmail.com>

Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>


[detached HEAD 0bf2d0ba07] util: preserve length of deprecated functions

Author: LiviaMedeiros <livia@cirno.name>

Date: Wed Apr 9 23:46:59 2025 +0800

2 files changed, 22 insertions(+)

Rebasing (3/4)

Rebasing (4/4)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

squash: mitigate prototype pollution


PR-URL: #57806

Reviewed-By: Jordan Harband <ljharb@gmail.com>

Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Reviewed-By: James M Snell <jasnell@gmail.com>

Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>


[detached HEAD f94ec3727e] squash: mitigate prototype pollution

Author: LiviaMedeiros <livia@cirno.name>

Date: Thu Apr 10 00:42:57 2025 +0800

1 file changed, 10 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.


ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.
https://github.com/nodejs/node/actions/runs/14407403600

@LiviaMedeiros LiviaMedeiros added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Apr 11, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 11, 2025
@nodejs-github-bot nodejs-github-bot merged commit 86f86a2 into nodejs:main Apr 11, 2025
@nodejs-github-bot

nodejs-github-bot commented Apr 11, 2025

Copy link
Copy Markdown
Collaborator

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@LiviaMedeiros @RafaelGSS
util: preserve length of deprecated functions
5783d3a 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@LiviaMedeiros @RafaelGSS
util: preserve length of deprecated functions
8ca56a8 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@LiviaMedeiros @aduh95
util: preserve length of deprecated functions
8421bcb 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@LiviaMedeiros @aduh95
util: preserve length of deprecated functions
93c16ff 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@LiviaMedeiros @RafaelGSS
util: preserve length of deprecated functions
f76893d 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@LiviaMedeiros @aduh95
util: preserve length of deprecated functions
d418622 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@LiviaMedeiros @aduh95
util: preserve length of deprecated functions
4ad4544 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@LiviaMedeiros @aduh95
util: preserve length of deprecated functions
bd44e93 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@LiviaMedeiros @aduh95
util: preserve length of deprecated functions
e346647 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@github-actions github-actions Bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@LiviaMedeiros @aduh95
util: preserve length of deprecated functions
30060e1 
PR-URL: #57806
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
@ghost ghost mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ljharb ljharb ljharb approved these changes
@jasnell jasnell jasnell approved these changes
@lpinca lpinca lpinca approved these changes
@BridgeAR BridgeAR BridgeAR approved these changes
@aduh95 aduh95 aduh95 approved these changes
@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@LiviaMedeiros @nodejs-github-bot @ljharb @jasnell @lpinca @BridgeAR @aduh95 @marco-ippolito