{{ message }}
src: support (de)serialization of DOMException#57372
Closed
jazelly wants to merge 1 commit into
Closed
Conversation
nodejs-github-bot
added
c++
jazelly
force-pushed
the
serialize-dom-exception
branch
2 times, most recently
from
c73bc7f to
b039fee
Compare
jazelly
force-pushed
the
serialize-dom-exception
branch
2 times, most recently
from
0aec3cf to
96f824c
Compare
github-actions
Bot
removed
the
request-ci
Collaborator
legendecas
reviewed
Mar 10, 2025
legendecas
left a comment
legendecas
left a comment
Member
There was a problem hiding this comment.
Private symbols are per-isolate data and initialized before an Environment is created (in IsolateData). It does not depend on an Environment. Yet, it needs a bit of refactor on the NewContext and GetPerContextExports so that InitializePrimordials can access the private symbols.
addaleax
reviewed
Mar 10, 2025
jazelly
force-pushed
the
serialize-dom-exception
branch
from
947742c to
ee1dacf
Compare
Member
Author
IIUC, we need to pass |
jazelly
force-pushed
the
serialize-dom-exception
branch
from
440dcd7 to
cded81b
Compare
ExE-Boss
reviewed
Mar 15, 2025
| constructor(message = '', options = 'Error') { | ||
| ErrorCaptureStackTrace(this); | ||
|
|
||
| this[is_dom_exception] = true; |
Contributor
There was a problem hiding this comment.
Maybe use class property syntax to set this using [[Define]] semantics?
class DOMException {
[is_dom_exception] = true;
constructor(message = '', options = 'Error') {
...
}
}
jazelly
force-pushed
the
serialize-dom-exception
branch
from
cded81b to
2ec57d7
Compare
Member
Author
jazelly
force-pushed
the
serialize-dom-exception
branch
from
2ec57d7 to
ed31a8c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added serialization and deserialization support for
DOMException. Ideally we shouldn't do this in native, but since it's compiled before an Environment exists, we cannot mark it askCloneableand provide associated serialization methods in JS land.Fixes: #49181