Add perf test for the new scan changes. by jdmarshall · Pull Request #908 · node-config/node-config · GitHub
Skip to content

Add perf test for the new scan changes.#908

Merged
jdmarshall merged 1 commit into
node-config:masterfrom
jdmarshall:benchscan
Apr 3, 2026
Merged

Add perf test for the new scan changes.#908
jdmarshall merged 1 commit into
node-config:masterfrom
jdmarshall:benchscan

Conversation

@jdmarshall

@jdmarshall jdmarshall commented Mar 29, 2026

Copy link
Copy Markdown
Collaborator

Addendum to #904

Summary by CodeRabbit

  • Tests
    • Added security testing configuration
    • Extended benchmark coverage for configuration version 4.4.0
    • Added performance benchmarks for file configuration loading operations

@coderabbitai

coderabbitai Bot commented Mar 29, 2026

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@benchmarks/config/pentest.json`:
- Around line 1-3: This pentest.json file is unused — remove
benchmarks/config/pentest.json from the repo; if it was intended to be loaded
instead, update the config loading code (loadFileConfigs) to accept "pentest" or
add references where it's used, but otherwise delete the file to avoid dead
config artifacts.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 7906e5df-6b6f-4f59-94a0-526124ec2e0a

📥 Commits

Reviewing files that changed from the base of the PR and between aca4e05 and 0393118.

📒 Files selected for processing (2)
  • benchmarks/config/pentest.json
  • benchmarks/index.js

Comment thread benchmarks/config/pentest.json
@jdmarshall jdmarshall merged commit 067970f into node-config:master Apr 3, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant