{{ message }}
Icing .iced files#902
Merged
Merged
Conversation
.iced files have never worked, not once, since introduction. And there are no tests to assert that it does. A function that never worked cannot be a breaking change, so this isn't. Addresses node-config#900
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
parser.js (1)
285-304:⚠️ Potential issue | 🔴 CriticalDon't remove the built-in
.icedregistration.Dropping
icedfromorderanddefinitionsmakes.icedfiles unresolvable through the built-in parser path:Parser.parse('config.iced', ...)now falls through toundefined, and callers also losegetParser('iced')/ built-in file-order discovery. That is the opposite of this PR's stated goal of restoring.icedsupport, so the extension needs to stay registered here until the replacement implementation is wired back in.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@parser.js` around lines 285 - 304, The change removed the built-in `.iced` registration causing Parser.parse('config.iced', ...) and getParser('iced') to fail; re-add 'iced' into the order array and restore an entry in definitions mapping 'iced' to the built-in parser (e.g., Parser.icedParser) so the extension is discoverable and resolvable via the existing Parser.parse and getParser flows; update both the order variable and the definitions object (referencing the symbols order, definitions, and Parser.icedParser) to restore behavior.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Outside diff comments:
In `@parser.js`:
- Around line 285-304: The change removed the built-in `.iced` registration
causing Parser.parse('config.iced', ...) and getParser('iced') to fail; re-add
'iced' into the order array and restore an entry in definitions mapping 'iced'
to the built-in parser (e.g., Parser.icedParser) so the extension is
discoverable and resolvable via the existing Parser.parse and getParser flows;
update both the order variable and the definitions object (referencing the
symbols order, definitions, and Parser.icedParser) to restore behavior.
Collaborator
Author
|
addresses #900 |
Collaborator
|
I accept this as a non-breaking change based on your rationale that it never worked. |
markstos
approved these changes
Mar 10, 2026
markstos
left a comment
markstos
left a comment
Collaborator
There was a problem hiding this comment.
QA Log
- Reviewed diff
- Noted there is nothing in package.json to remove.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.iced files have never worked, not once, since introduction. And there are no tests to assert that it does. A function that never worked cannot be a breaking change, so this isn't.
Addresses #900
This should ever so slightly improve the speed of scan() and thus library initialization.
Summary by CodeRabbit