fix: use-after-free in `get_data_from_buffer` by KowalskiThomas · Pull Request #677 · msgpack/msgpack-python · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions msgpack/_unpacker.pyx
2 changes: 1 addition & 1 deletion msgpack/fallback.py
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ def feed(self, next_bytes):
self._buf_checkpoint = 0

# Use extend here: INPLACE_ADD += doesn't reliably typecast memoryview in jython
self._buffer.extend(view)
self._buffer.extend(view if view.contiguous else view.tobytes())
view.release()
Comment thread
KowalskiThomas marked this conversation as resolved.

def _consume(self):
Expand Down
12 changes: 12 additions & 0 deletions test/test_memoryview.py
Loading