{{ message }}
encoder: Encode instances of Number as numbers, not maps#271
Open
FlorianDenis wants to merge 2 commits into
Open
encoder: Encode instances of Number as numbers, not maps#271FlorianDenis wants to merge 2 commits into
FlorianDenis wants to merge 2 commits into
Conversation
Member
|
Why do you use the |
Author
|
I am not going to go too much into the details of my project because this is not the place, but it turns out that I have a need for representing a integer using an object instance rather than a primitive type, a need which My goal with this PR is merely to point out that
|
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure instances of
Numberas encoded as anumberinstead of amap.I am encountering this issue in my current project, I believe this is a more sensible default behavior
All tests pass.