Reuse Encoder/Decoder instance by buu700 · Pull Request #177 · msgpack/msgpack-javascript · GitHub
Skip to content

Reuse Encoder/Decoder instance#177

Open
buu700 wants to merge 1 commit into
msgpack:mainfrom
buu700:encoder-instance-reuse
Open

Reuse Encoder/Decoder instance#177
buu700 wants to merge 1 commit into
msgpack:mainfrom
buu700:encoder-instance-reuse

Conversation

@buu700

@buu700 buu700 commented May 5, 2021

Copy link
Copy Markdown

Addresses #172

@buu700 buu700 force-pushed the encoder-instance-reuse branch from d338d94 to 381f7e0 Compare May 5, 2021 00:24
@gfx

gfx commented May 5, 2021

Copy link
Copy Markdown
Member

@gfx

gfx commented May 5, 2021

Copy link
Copy Markdown
Member

Ah, right. It only changes the synchronous functions, although CI failed. It looks good.

Could you take a look at CI failure? I'll merge this PR if CI passes.

@buu700 buu700 force-pushed the encoder-instance-reuse branch from 381f7e0 to 252ea39 Compare May 5, 2021 01:39
@buu700

buu700 commented May 5, 2021

Copy link
Copy Markdown
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants