{{ message }}
FindCImg.cmake: Propagate png and jpeg library paths properly#328
Merged
Conversation
According to FindPkgConfig documentation, the ${prefix}_LINK_LIBRARIES expands
to a full path to the library. This is what we want to pass to
target_link_libraries() later, because this allows CMake to properly generate
-L and -l flags. Using just ${prefix}_LIBRARIES works on Linux, where libraries
are put in the default library search path, but fails on FreeBSD.
This change does not fix the case for STATIC_BUILD due to bug on the CMake side:
Kitware/CMake@7e4adca
TheAssassin
approved these changes
Apr 21, 2026
TheAssassin
left a comment
TheAssassin
left a comment
Member
There was a problem hiding this comment.
Looks good to me. Let's see if CI agrees. Thanks!
Member
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to FindPkgConfig documentation, the ${prefix}_LINK_LIBRARIES expands to a full path to the library. This is what we want to pass to target_link_libraries() later, because this allows CMake to properly generate -L and -l flags. Using just ${prefix}_LIBRARIES works on Linux, where libraries are put in the default library search path, but fails on FreeBSD.
This change does not fix the case for STATIC_BUILD due to bug on the CMake side: Kitware/CMake@7e4adca