🌱 chore(ci/crd) Add new test to ensure that pointer embedded structs with the inline JSON tag works by camilamacedo86 · Pull Request #1395 · kubernetes-sigs/controller-tools · GitHub
Skip to content

🌱 chore(ci/crd) Add new test to ensure that pointer embedded structs with the inline JSON tag works - #1395

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
camilamacedo86:fix-inline
Jun 26, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:mainfrom
camilamacedo86:fix-inline

Conversation

@camilamacedo86

@camilamacedo86 camilamacedo86 commented Apr 27, 2026 •

Copy link
Copy Markdown
Member

Closes: #773

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2026
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 27, 2026
@JoelSpeed

Copy link
Copy Markdown
Contributor

/approve
/lgtm

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 26, 2026
@kubernetes-prow

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 5393798396b1e098e9a93e7cd3e32604807f414a

@kubernetes-prow

Copy link
Copy Markdown
Contributor

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 26, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit b2579dd into kubernetes-sigs:main Jun 26, 2026
7 checks passed
@camilamacedo86
camilamacedo86 deleted the fix-inline branch June 28, 2026 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent inline behaviour for embedded structs depending on pointer/value type

3 participants