{{ message }}
refactor: improve toClassName function readability and JSDoc completeness#112
Merged
Merged
Conversation
UlisesGascon
approved these changes
Nov 11, 2024
wesleytodd
approved these changes
Nov 12, 2024
wesleytodd
left a comment
wesleytodd
left a comment
Member
There was a problem hiding this comment.
While I am not a huge fan of PR's with changes like the code reformatting which do not have meaningful behavior changes (so maybe try to avoid those in the future) I think it is more readable, and the JSDoc updates are also good. Since this PR has been open for 5 days and has now two approvals I think we can merge.
…ness - Replaced substr with slice for better readability and consistency. - Updated JSDoc to include @param and @returns tags for clarity on function inputs and outputs. - Simplified the conditional logic by using slice(-5) === 'Error' for a concise and clear check.
wesleytodd
force-pushed
the
chore/toClassName
branch
from
373bbbc to
9d35422
Compare
Contributor
Author
Member
Merged
mattbishop
reviewed
Jan 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor: improve
toClassNamefunction readability and JSDoc completenesssubstrwithslicefor better readability and consistency.@paramand@returnstags for clarity on function inputs and outputs.slice(-5) === 'Error'for a concise and clear check.