{{ message }}
Fix memory leak and handle errors gracefully in LLM autosuggester#15275
Open
aakritiieee7 wants to merge 1 commit into
Open
Fix memory leak and handle errors gracefully in LLM autosuggester#15275aakritiieee7 wants to merge 1 commit into
aakritiieee7 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR resolves a memory leak in the auto-suggestion subsystem of the terminal interactive shell, fixes an incorrect default value in the prefixer, and improves robustness against cancellations and API errors.
Changes
disconnectmethod ofNavigableAutoSuggestFromHistorywas updated to remove_dismissfrom the buffer'son_cursor_position_changedevent. Previously, only theon_text_inserthandler was removed, resulting in a leak where the auto-suggester remained referenced by the event._llm_prefixerdefault implementation from returning"wrong"to"".await self._llm_taskexecution in a try-except block to catchasyncio.CancelledErrorandException. This ensures that natural task cancellations (during cursor movement) or LLM provider errors do not bubble up to prompt_toolkit and crash the prompt.Testing Checklist
on_cursor_position_changedhandler is removed upon disconnect.CancelledError.