{{ message }}
fix: add __kwdefaults__, __annotations__, __type_params__ to autorelo…#15274
Open
sid0229 wants to merge 1 commit into
Open
fix: add __kwdefaults__, __annotations__, __type_params__ to autorelo…#15274sid0229 wants to merge 1 commit into
sid0229 wants to merge 1 commit into
Conversation
…ad func_attrs Fixes ipython#14968 autoreload's update_function() was not patching __kwdefaults__, __annotations__, or __type_params__ when reloading a changed function. This meant that after editing a module, keyword-only argument defaults, type annotations, and PEP 695 type params would remain stale until the session was restarted. __kwdefaults__ and __annotations__ are patched unconditionally; __type_params__ (Python 3.12+, PEP 695) is handled safely by the existing try/except (AttributeError, TypeError) in update_function().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ad func_attrs
Fixes #14968
autoreload's update_function() was not patching kwdefaults, annotations, or type_params when reloading a changed function. This meant that after editing a module, keyword-only argument defaults, type annotations, and PEP 695 type params would remain stale until the session was restarted.
kwdefaults and annotations are patched unconditionally; type_params (Python 3.12+, PEP 695) is handled safely by the existing try/except (AttributeError, TypeError) in update_function().