{{ message }}
Fix oinspect TypeError with generic __getattr__ objects; fix test path quoting#15246
Merged
Conversation
…h quoting oinspect: guard __custom_documentations__ lookup with isinstance(dict) so objects like polars Expr (which return self for any attribute access via __getattr__) no longer raise TypeError when inspected with ?. Fixes #15072. oinspect: fix inspect.Parameter.empty comparison in MIME-hook path; the previous code accidentally compared against the property descriptor object rather than the sentinel, making the required-parameter filter a no-op. test_interactiveshell: wrap sys.executable and self.fname in shlex.quote() so test_exit_code_signal survives when the source path contains spaces. Fixes #15100. https://claude.ai/code/session_01VPnGTgifZ8HMAfiqEVftjj
Carreau
force-pushed
the
claude/amazing-wright-zhq3c
branch
from
5845388 to
7be0fd7
Compare
Carreau
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-picked the first commit from #15237.
__custom_documentations__lookup withisinstance(dict)so objects like polarsExpr(which returnselffor any attribute access via__getattr__) no longer raiseTypeErrorwhen inspected with?. Fixes oinspect throws TypeError when parsing incomplete code line involving polars.expr.expr #15072.inspect.Parameter.emptycomparison in the MIME-hook path; the previous code accidentally compared against the property descriptor object rather than the sentinel, making the required-parameter filter a no-op.sys.executableandself.fnameinshlex.quote()sotest_exit_code_signalsurvives when the source path contains spaces. Fixes Test failures when path to IPython source code contains spaces #15100.