{{ message }}
Add unit tests for ExhaustedDataLoaderDispatchStrategy#4306
Merged
Conversation
Add 8 deterministic tests that directly exercise the concurrent state machine in ExhaustedDataLoaderDispatchStrategy, recovering branch and line coverage lost when PR #4299 replaced race-condition-dependent timing with deterministic latch-based synchronization. Tests cover: - Basic dispatch cycle (finishedFetching triggers dispatch) - Early return in newDataLoaderInvocation when flag already set - Dispatch from newDataLoaderInvocation when objectRunningCount is 0 - Multiple dispatch rounds with chained data loader invocations - executionSerialStrategy state reset - Subscription alternative call context with separate call stack - startComplete/stopComplete dispatch coordination - Deferred call context lazy call stack creation via computeIfAbsent https://claude.ai/code/session_01WwTVwjXS1wakJQmZYsXLvY
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ExhaustedDataLoaderDispatchStrategyto recover branch and line coverage lost by PR Fix flaky DataLoaderPerformanceTest with deterministic synchronization #4299's switch from race-condition-dependent timing to deterministic latch-based synchronizationfinishedFetchingandnewDataLoaderInvocation, the early-return whendataLoaderToDispatchis already set, multi-round dispatch with chained loading, serial strategy reset, subscription/deferred alternate call stacks, andstartComplete/stopCompletecoordinationTest plan
ExhaustedDataLoaderDispatchStrategyhttps://claude.ai/code/session_01WwTVwjXS1wakJQmZYsXLvY