deps: update all tracing and telemetry dependencies by olavloite · Pull Request #4230 · googleapis/java-spanner · GitHub
Skip to content
This repository was archived by the owner on Apr 7, 2026. It is now read-only.

deps: update all tracing and telemetry dependencies#4230

Merged
rahul2393 merged 2 commits into
mainfrom
update-trace-deps
Nov 17, 2025
Merged

deps: update all tracing and telemetry dependencies#4230
rahul2393 merged 2 commits into
mainfrom
update-trace-deps

Conversation

@olavloite

Copy link
Copy Markdown
Collaborator

Update all tracing and telemetry dependencies in one PR, and create property definitions for versions that should be updated in sync.

@olavloite olavloite requested review from a team November 17, 2025 13:34
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/java-spanner API. labels Nov 17, 2025
@gemini-code-assist

Copy link
Copy Markdown
Contributor

rahul2393
rahul2393 previously approved these changes Nov 17, 2025

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively updates several tracing and telemetry dependencies and introduces properties to manage their versions, which is a great improvement for maintainability. My review includes a few suggestions to apply this practice more consistently across the POM files by replacing some remaining hardcoded versions with properties. This will further align the changes with the PR's goal.

Comment thread benchmarks/pom.xml
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<junixsocket.version>2.10.1</junixsocket.version>
<opentelemetry.version>1.56.0</opentelemetry.version>
<google.cloud.monitoring.version>3.81.0</google.cloud.monitoring.version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and consistency with the goal of this PR, consider defining a property for the google.cloud.opentelemetry dependencies as well. The dependencies exporter-trace (line 53) and exporter-metrics (line 58) use a hardcoded version 0.36.0. You can define the property here and then use it for those dependencies.

    <google.cloud.monitoring.version>3.81.0</google.cloud.monitoring.version>
    <google.cloud.opentelemetry.version>0.36.0</google.cloud.opentelemetry.version>

<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-trace</artifactId>
<version>2.76.0</version>
<version>2.79.0</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This version is hardcoded. The proto-google-cloud-trace-v1 dependency on line 153 also has a hardcoded version 2.79.0. To align with the goal of this PR to use properties for synchronized versions, consider defining a property like <google.cloud.trace.version>2.79.0</google.cloud.trace.version> in the <properties> section and using it here and for the other dependency.

Suggested change
<version>2.79.0</version>
<version>${google.cloud.trace.version}</version>

<groupId>com.google.cloud.opentelemetry</groupId>
<artifactId>exporter-trace</artifactId>
<version>0.33.0</version>
<version>0.36.0</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version for exporter-trace is hardcoded. To improve maintainability and align with the PR's goal, please define a property <google.cloud.opentelemetry.version>0.36.0</google.cloud.opentelemetry.version> in the <properties> section of this POM (e.g., on line 19) and use it here.

Suggested change
<version>0.36.0</version>
<version>${google.cloud.opentelemetry.version}</version>

<groupId>com.google.cloud</groupId>
<artifactId>google-cloud-trace</artifactId>
<version>2.76.0</version>
<version>2.79.0</version>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The version for google-cloud-trace is hardcoded. The proto-google-cloud-trace-v1 dependency on line 515 also has a hardcoded version 2.79.0. To improve maintainability, consider defining a property like <google.cloud.trace.version>2.79.0</google.cloud.trace.version> in the <properties> section (e.g., on line 19) and using it for both dependencies.

Suggested change

@rahul2393 rahul2393 merged commit d60124c into main Nov 17, 2025
41 of 43 checks passed
@rahul2393 rahul2393 deleted the update-trace-deps branch November 17, 2025 14:36
gcf-merge-on-green Bot pushed a commit that referenced this pull request Nov 17, 2025
🤖 I have created a release *beep* *boop*
---


## [6.103.0](https://togithub.com/googleapis/java-spanner/compare/v6.102.1...v6.103.0) (2025-11-17)


### Features

* Add grpc.xds.resource_type label to xDS client metrics ([#4222](https://togithub.com/googleapis/java-spanner/issues/4222)) ([97bed3c](https://togithub.com/googleapis/java-spanner/commit/97bed3cf1a9df542acc4685c2ce4dbfa629b2cd3))
* Exposing AutoscalingConfig in InstancePartition ([22edecf](https://togithub.com/googleapis/java-spanner/commit/22edecf8518844860c3cb47883544efd36cbc311))


### Bug Fixes

* Add env var to allow disabling directpath bound token ([#4189](https://togithub.com/googleapis/java-spanner/issues/4189)) ([0ca9541](https://togithub.com/googleapis/java-spanner/commit/0ca95412c778e3478cb66e4bea124396326c6056))
* Allow DML THEN RETURN with retryAbortsInternally=false ([#4225](https://togithub.com/googleapis/java-spanner/issues/4225)) ([f49cc47](https://togithub.com/googleapis/java-spanner/commit/f49cc47e663836696ef151738510e68324e139dc))
* **deps:** Update the Java code generator (gapic-generator-java) to 2.64.1 ([22edecf](https://togithub.com/googleapis/java-spanner/commit/22edecf8518844860c3cb47883544efd36cbc311))
* Remove URL encoding in project name ([#4188](https://togithub.com/googleapis/java-spanner/issues/4188)) ([abba0c1](https://togithub.com/googleapis/java-spanner/commit/abba0c1730ea792407bea073ea65da55128cd764))


### Dependencies

* Update actions/checkout action to v5 ([#4166](https://togithub.com/googleapis/java-spanner/issues/4166)) ([50a56f7](https://togithub.com/googleapis/java-spanner/commit/50a56f7d47541dd581f7b425df36a080ecc11a74))
* Update all tracing and telemetry dependencies ([#4230](https://togithub.com/googleapis/java-spanner/issues/4230)) ([d60124c](https://togithub.com/googleapis/java-spanner/commit/d60124cbe317d4c2489ea35de81943cfd2b8f697))
* Update dependency com.google.api.grpc:proto-google-cloud-trace-v1 to v2.79.0 ([#4172](https://togithub.com/googleapis/java-spanner/issues/4172)) ([3a329fd](https://togithub.com/googleapis/java-spanner/commit/3a329fdb2fc68ff9d19717b534dd667f931d51fd))
* Update dependency com.google.auto.value:auto-value-annotations to v1.11.1 ([#4216](https://togithub.com/googleapis/java-spanner/issues/4216)) ([84150c7](https://togithub.com/googleapis/java-spanner/commit/84150c73bbed2a6d58408ae0b8bd59709fc751db))
* Update dependency com.google.cloud:google-cloud-trace to v2.79.0 ([#4174](https://togithub.com/googleapis/java-spanner/issues/4174)) ([3e93ca0](https://togithub.com/googleapis/java-spanner/commit/3e93ca077b94ad06867e3c9fdfe19527855423a2))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.54.1 ([#4193](https://togithub.com/googleapis/java-spanner/issues/4193)) ([ad235cf](https://togithub.com/googleapis/java-spanner/commit/ad235cfc9041f52c2f7b76f67eeaa6c03c5840aa))
* Update dependency commons-cli:commons-cli to v1.11.0 ([#4218](https://togithub.com/googleapis/java-spanner/issues/4218)) ([33449ba](https://togithub.com/googleapis/java-spanner/commit/33449baf64a3d5b78fff323737ffeb28c8a9461b))
* Update dependency commons-io:commons-io to v2.21.0 ([#4198](https://togithub.com/googleapis/java-spanner/issues/4198)) ([1f31169](https://togithub.com/googleapis/java-spanner/commit/1f3116947069ac11c948b510e6a9a7a8a6aa6061))
* Update dependency net.bytebuddy:byte-buddy to v1.18.1 ([#4214](https://togithub.com/googleapis/java-spanner/issues/4214)) ([0c1d843](https://togithub.com/googleapis/java-spanner/commit/0c1d843ad42f213d4d9ec2d98a12e21e991ac010))
* Update dependency net.bytebuddy:byte-buddy-agent to v1.18.1 ([#4215](https://togithub.com/googleapis/java-spanner/issues/4215)) ([76ce01b](https://togithub.com/googleapis/java-spanner/commit/76ce01b99e5c1274e9103c27ebc6bbdf482bebcd))
* Update opentelemetry.version to v1.56.0 ([#4167](https://togithub.com/googleapis/java-spanner/issues/4167)) ([a24f219](https://togithub.com/googleapis/java-spanner/commit/a24f21930978583a0b8d7d39130fa0fc3fec7b2d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants