chore(bigquery): migrate to std::optional#16210
Conversation
product-auto-label
Bot
added
the
api: bigquery
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces the use of absl::optional with std::optional across several files in the BigQuery v2 minimal internal library, aligning with C++17 standards. The reviewer suggests returning std::optional<std::chrono::system_clock::time_point> by value instead of by const& in ListJobsRequest because it is a small, trivially copyable type, which avoids pointer indirection and potential lifetime issues.
There was a problem hiding this comment.
Since std::chrono::system_clock::time_point is a small, trivially copyable type, std::optional<std::chrono::system_clock::time_point> is also small and cheap to copy. Returning it by value instead of by const& is more idiomatic in C++, avoids pointer indirection overhead, and prevents potential lifetime issues (dangling references) for callers.
std::optional<std::chrono::system_clock::time_point>
min_creation_time() const {
return min_creation_time_;
}
std::optional<std::chrono::system_clock::time_point>
max_creation_time() const {
return max_creation_time_;
}
1 participant
Replacing explicit usages of absl::optional with std::optional in the BigQuery Client library as part of broader modernization efforts