feat(networksecurity): update library by scotthart · Pull Request #16122 · googleapis/google-cloud-cpp · GitHub
Skip to content

feat(networksecurity): update library#16122

Merged
scotthart merged 5 commits into
googleapis:mainfrom
scotthart:feat-networksecurity-generate-library
May 27, 2026
Merged

feat(networksecurity): update library#16122
scotthart merged 5 commits into
googleapis:mainfrom
scotthart:feat-networksecurity-generate-library

Conversation

@scotthart

Copy link
Copy Markdown
Member

PiperOrigin-RevId: 919268561

@product-auto-label product-auto-label Bot added the api: networksecurity Issues related to the Network Security API API. label May 27, 2026
@scotthart scotthart marked this pull request as ready for review May 27, 2026 16:24
@scotthart scotthart requested a review from a team as a code owner May 27, 2026 16:24

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several new services to the Network Security API C++ client library, including Address Group, DNS Threat Detector, Firewall Activation, and Intercept. It generates the corresponding client, connection, stub, and decorator classes, and updates the documentation and configuration files. The review feedback highlights critical compilation errors in address_group_client.cc where iterators are incorrectly assigned to a RepeatedPtrField, and a formatting issue in CHANGELOG.md with an empty markdown link placeholder.

Comment thread google/cloud/networksecurity/v1/address_group_client.cc
Comment thread google/cloud/networksecurity/v1/address_group_client.cc
Comment thread google/cloud/networksecurity/v1/address_group_client.cc
Comment thread google/cloud/networksecurity/v1/address_group_client.cc
Comment thread CHANGELOG.md
@codecov

codecov Bot commented May 27, 2026

Copy link
Copy Markdown

@scotthart scotthart enabled auto-merge (squash) May 27, 2026 17:10
@scotthart scotthart merged commit 00f057d into googleapis:main May 27, 2026
56 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: networksecurity Issues related to the Network Security API API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants