{{ message }}
feat(storage): Add full object checksum validation for appendable uploads#16110
Merged
v-pratap merged 15 commits intoMay 26, 2026
Conversation
There was a problem hiding this comment.
Code Review
This pull request implements dynamic CRC32C validation for appendable object uploads by updating the connection and writer logic to initialize hash functions from RPC response metadata. It also adds a stateful constructor to the CRC32C hash function. Feedback highlights a critical regression where a large suite of existing integration tests was deleted and replaced with experimental code. Additional suggestions include adding defensive checks for CRC32C field presence, utilizing existing library thread management instead of a custom thread pool in tests, and using environment variables instead of hardcoded strings for test configuration.
kalragauri
reviewed
May 25, 2026
raulrojasalvarez779-web
approved these changes
May 25, 2026
raulrojasalvarez779-web
approved these changes
May 25, 2026
raulrojasalvarez779-web
approved these changes
May 25, 2026
raulrojasalvarez779-web
approved these changes
May 25, 2026
raulrojasalvarez779-web
approved these changes
May 25, 2026
raulrojasalvarez779-web
approved these changes
May 25, 2026
18389a0 to
58d4b1d
Compare
raulrojasalvarez779-web
approved these changes
May 25, 2026
kalragauri
requested changes
May 26, 2026
kalragauri
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

No description provided.