Export typing information by JanLuca · Pull Request #923 · google/TensorNetwork · GitHub
Skip to content
This repository was archived by the owner on Nov 7, 2024. It is now read-only.

Export typing information#923

Open
JanLuca wants to merge 2 commits into
google:masterfrom
JanLuca:export_typing
Open

Export typing information#923
JanLuca wants to merge 2 commits into
google:masterfrom
JanLuca:export_typing

Conversation

@JanLuca

@JanLuca JanLuca commented May 20, 2021

Copy link
Copy Markdown

This commit adds the flag that the package contains typing
information. Therefore other packages can use the typing data to check their
code by mypy.

Ref.: https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages

Signed-off-by: Jan Luca Naumann j.naumann@fu-berlin.de

This commit adds the flag that the package contains typing
information. Therefore other packages can use the typing data to check their
code by mypy.

Ref.: https://mypy.readthedocs.io/en/stable/installed_packages.html#making-pep-561-compatible-packages

Signed-off-by: Jan Luca Naumann <j.naumann@fu-berlin.de>
@google-cla

google-cla Bot commented May 20, 2021

Copy link
Copy Markdown

@google-cla google-cla Bot added the cla: no label May 20, 2021
@JanLuca

JanLuca commented May 20, 2021

Copy link
Copy Markdown
Author

@googlebot I signed it!

@google-cla google-cla Bot added cla: yes and removed cla: no labels May 20, 2021

@alewis alewis left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mganahl

mganahl commented May 31, 2021

Copy link
Copy Markdown
Contributor

Thanks for the PR! I'll fix the build and merge this.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Merging #923 (357f430) into master (20dc783) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #923   +/-   ##
=======================================
  Coverage   98.04%   98.04%           
=======================================
  Files         129      129           
  Lines       22394    22394           
=======================================
  Hits        21957    21957           
  Misses        437      437           
Impacted Files Coverage Δ
setup.py 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20dc783...357f430. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants