{{ message }}
fix: fix incoherent beginning whitespace#1933
Merged
Merged
Conversation
Byron
approved these changes
Jun 18, 2024
Byron
left a comment
Member
There was a problem hiding this comment.
Thanks a lot for this fix, that's better!
I wonder if the strip("\n") has to happen at all, it's unusual to have newlines in paths anyway, and if they are there, they should not be removed.
In other words, what happens if there is no strip() call?
Contributor
Author
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Some repositories contain files / directories beginning by a space in their history (example : react-component/field-form@0e81dc0).
The current version of GitPython returns this space sometimes when doing a diff (depending on whether the space is in
a_pathorb_path).This is due to a
stripbeing done to the path (see the only line changed indiff.py). This PR make a simple change by not stripping the spaces, but only new lines (we can also add other characters if needed) so the behavior stays coherent and the white space is given when doing a diff. An alternative would be to remove thestrip(some tests started failing when doing so...).