{{ message }}
Repository navigation
Fix Assembly heuristics to remove char class duplication - #7265
Merged
Merged
Conversation
lildude
changed the title
character class has duplicated range warning
lildude
reviewed
Mar 5, 2025
lildude
approved these changes
Mar 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#7229 introduced changes to the Assembly heuristics that included character class duplication which were reported as warnings in CI but missed at the time:
For future reference, @donno2048, useful PR bodies like this are preferred over simple pings as context is needed for reviewing by those unfamiliar at the time or who question the change in future.