{{ message }}
Repository navigation
feat(core): Use maxValueLength on error messages - #18301
Merged
Merged
Conversation
3 tasks done
Contributor
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application. |
Lms24
approved these changes
Nov 24, 2025
Lms24
left a comment
Lms24
left a comment
Member
There was a problem hiding this comment.
Nice! I like the idea of offering a way to truncate but not do it by default!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It can happen that error messages are too long and exceed the maximum envelope size (mentioned in #18219).
maxValueLengthnow also checks for long error messages and truncates them.