{{ message }}
Repository navigation
fix: inherit sandbox flags in windows opened by a sandboxed top-level frame - #52848
Merged
Conversation
… frame WebContents::OpenURLFromTab only propagated the initiating frame's sandbox flags to the window it created when that frame had a parent. A top-level frame can carry a non-empty sandboxing flag set as well (via a sandboxed iframe's popup, or a Content-Security-Policy: sandbox header), so resolve and apply the initiator's active sandbox flags regardless of its position in the frame tree. Co-authored-by: Sam Attard <sattard@anthropic.com>
MarshallOfSound
approved these changes
Aug 16, 2026
trop
Bot
added
43-x-y
backport
MarshallOfSound
enabled auto-merge (squash)
August 16, 2026 10:31
MarshallOfSound
deleted the
trop/43-x-y-bp-fix-inherit-sandbox-flags-in-windows-opened-by-a-sandboxed-top-level-frame-1786876176089
branch
August 16, 2026 12:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #52841
See that PR for details.
Notes: Fixed windows opened by a sandboxed top-level frame not inheriting the opener's sandbox restrictions.