fix: inherit nodeIntegrationInWorker from the embedder for <webview> and window.open by trop[bot] · Pull Request #52832 · electron/electron · GitHub
Skip to content

fix: inherit nodeIntegrationInWorker from the embedder for <webview> and window.open - #52832

Merged
MarshallOfSound merged 1 commit into
44-x-yfrom
trop/44-x-y-bp-fix-inherit-nodeintegrationinworker-from-the-embedder-for-webview-and-window-open-1786835149322
Aug 16, 2026
Merged

MarshallOfSound merged 1 commit into
44-x-yfrom
trop/44-x-y-bp-fix-inherit-nodeintegrationinworker-from-the-embedder-for-webview-and-window-open-1786835149322

Conversation

@trop

@trop trop Bot commented Aug 15, 2026

Copy link
Copy Markdown
Contributor

Backport of #52823

See that PR for details.

Notes: <webview> and window.open now inherit nodeIntegrationInWorker from the embedder, consistent with the other Node and sandbox preferences.

…and window.open

The list of security options a <webview> guest always inherits from its
embedder, and the equivalent list child windows inherit from their parent,
omitted nodeIntegrationInWorker. As a result the webpreferences attribute
could set nodeIntegrationInWorker on a guest whose embedder had it disabled,
giving the guest's dedicated workers a Node environment the embedder itself
did not grant (and, with an unsandboxed embedder, dropping the guest out of
the sandbox). Add nodeIntegrationInWorker to both inheritance lists so a
guest can never be less secure than its embedder for this option.

Co-authored-by: Sam Attard <sattard@anthropic.com>
@trop trop Bot added 44-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Aug 15, 2026
@MarshallOfSound
MarshallOfSound enabled auto-merge (squash) August 15, 2026 23:07
@MarshallOfSound
MarshallOfSound merged commit b3ae0aa into 44-x-y Aug 16, 2026
92 checks passed
@MarshallOfSound
MarshallOfSound deleted the trop/44-x-y-bp-fix-inherit-nodeintegrationinworker-from-the-embedder-for-webview-and-window-open-1786835149322 branch August 16, 2026 00:30
@release-clerk

release-clerk Bot commented Aug 16, 2026

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

44-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant