fix: don't show empty autofill popup by trop[bot] · Pull Request #52320 · electron/electron · GitHub
Skip to content

fix: don't show empty autofill popup - #52320

Merged
ckerr merged 2 commits into
41-x-yfrom
trop/41-x-y-bp-fix-don-t-show-empty-autofill-popup-1783957073076
Jul 14, 2026
Merged

ckerr merged 2 commits into
41-x-yfrom
trop/41-x-y-bp-fix-don-t-show-empty-autofill-popup-1783957073076

Conversation

@trop

@trop trop Bot commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Backport of #52262

See that PR for details.

Notes: Fixed unnecessary autofill popup creation for fields without datalist suggestions, which could cause input latency on macOS.

trop Bot and others added 2 commits July 13, 2026 15:38
Co-authored-by: Noah Gregory <nmggithub@electronjs.org>
A hostile renderer could send values without matching labels and crash
the browser process via out-of-range label access in label_at(). Also
route the hide through HideAutofillPopup() for consistency and add
comments explaining the guards.

Co-authored-by: Samuel Attard <sattard@anthropic.com>
@trop
trop Bot requested a review from nmggithub July 13, 2026 15:38
@trop trop Bot mentioned this pull request Jul 13, 2026
4 of 5 tasks
@trop trop Bot added 41-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes labels Jul 13, 2026
@ckerr
ckerr merged commit 4c3df5b into 41-x-y Jul 14, 2026
77 checks passed
@ckerr
ckerr deleted the trop/41-x-y-bp-fix-don-t-show-empty-autofill-popup-1783957073076 branch July 14, 2026 23:11
@release-clerk

release-clerk Bot commented Jul 14, 2026

Copy link
Copy Markdown

renovate Bot added a commit to cigaleapp/cigale that referenced this pull request Aug 2, 2026
##### [v43.2.0](https://github.com/electron/electron/releases/tag/v43.2.0)

### Release Notes for v43.2.0

#### Features

- Added `net.WebSocket`, a WHATWG-compatible WebSocket client for the main process that routes through Chromium's network stack. [#52344](electron/electron#52344) <sup>(Also in [42](https://github.com/electron/electron/pull/52345))</sup>

#### Fixes

- Fixed `app.disableHardwareAcceleration()` not fully disabling GPU hardware usage on Windows starting from Electron 38. [#52369](electron/electron#52369) <sup>(Also in [41](electron/electron#52368), [42](electron/electron#52371), [44](https://github.com/electron/electron/pull/52370))</sup>
- Fixed `globalShortcut` not working on GNOME Wayland by enabling Chromium's `GlobalShortcutsPortalPreferredTrigger` feature by default on Linux. [#52228](electron/electron#52228)
- Fixed a crash when showing Linux message boxes while another Linux UI implementation was active. [#52410](electron/electron#52410) <sup>(Also in [42](electron/electron#52408), [44](https://github.com/electron/electron/pull/52409))</sup>
- Fixed a window being marked hidden and background-throttled on macOS when covered by a transparent or click-through window. [#52389](electron/electron#52389) <sup>(Also in [44](https://github.com/electron/electron/pull/52391))</sup>
- Fixed unnecessary autofill popup creation for fields without datalist suggestions, which could cause input latency on macOS. [#52321](electron/electron#52321) <sup>(Also in [41](electron/electron#52320), [42](electron/electron#52319), [44](https://github.com/electron/electron/pull/52318))</sup>
- Fixed webContents.print() returning "Invalid printer settings" when print options are provided. [#52381](electron/electron#52381) <sup>(Also in [44](https://github.com/electron/electron/pull/52382))</sup>

#### Other Changes

- Updated Chromium to 150.0.7871.129. [#52355](electron/electron#52355)
renovate Bot added a commit to cigaleapp/cigale that referenced this pull request Aug 3, 2026
##### [v43.2.0](https://github.com/electron/electron/releases/tag/v43.2.0)

### Release Notes for v43.2.0

#### Features

- Added `net.WebSocket`, a WHATWG-compatible WebSocket client for the main process that routes through Chromium's network stack. [#52344](electron/electron#52344) <sup>(Also in [42](https://github.com/electron/electron/pull/52345))</sup>

#### Fixes

- Fixed `app.disableHardwareAcceleration()` not fully disabling GPU hardware usage on Windows starting from Electron 38. [#52369](electron/electron#52369) <sup>(Also in [41](electron/electron#52368), [42](electron/electron#52371), [44](https://github.com/electron/electron/pull/52370))</sup>
- Fixed `globalShortcut` not working on GNOME Wayland by enabling Chromium's `GlobalShortcutsPortalPreferredTrigger` feature by default on Linux. [#52228](electron/electron#52228)
- Fixed a crash when showing Linux message boxes while another Linux UI implementation was active. [#52410](electron/electron#52410) <sup>(Also in [42](electron/electron#52408), [44](https://github.com/electron/electron/pull/52409))</sup>
- Fixed a window being marked hidden and background-throttled on macOS when covered by a transparent or click-through window. [#52389](electron/electron#52389) <sup>(Also in [44](https://github.com/electron/electron/pull/52391))</sup>
- Fixed unnecessary autofill popup creation for fields without datalist suggestions, which could cause input latency on macOS. [#52321](electron/electron#52321) <sup>(Also in [41](electron/electron#52320), [42](electron/electron#52319), [44](https://github.com/electron/electron/pull/52318))</sup>
- Fixed webContents.print() returning "Invalid printer settings" when print options are provided. [#52381](electron/electron#52381) <sup>(Also in [44](https://github.com/electron/electron/pull/52382))</sup>

#### Other Changes

- Updated Chromium to 150.0.7871.129. [#52355](electron/electron#52355)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

41-x-y backport This is a backport PR semver/patch backwards-compatible bug fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant